knotmirror,spindle,appview: propagate repo rename across services #275

appview/db/repos_rename_test.go

reviewed

This file has not been changed.

+14 -11

appview/repo/rename_test.go

reviewed

··· 6 6 ) 7 7 8 8 func TestValidateRenameInput(t *testing.T) { 9 9 + const validTID = "3jzfcijpj2z2a" 9 10 cases := []struct { 10 11 name string 11 12 currentName string 13 13 + currentRkey string 12 14 raw string 13 15 wantName string 14 16 wantErrSub string 15 17 }{ 16 16 - {"happy path", "foo", "bar", "bar", ""}, 17 17 - {"trims surrounding whitespace", "foo", " bar ", "bar", ""}, 18 18 - {"strips .git suffix", "foo", "bar.git", "bar", ""}, 19 19 - {"empty after trim", "foo", " ", "", "cannot be empty"}, 20 20 - {"raw empty", "foo", "", "", "cannot be empty"}, 21 21 - {"path traversal slash", "foo", "../bar", "", "invalid path"}, 22 22 - {"invalid character", "foo", "ba r", "", "alphanumeric"}, 23 23 - {"same name as current", "foo", "foo", "", "matches the current name"}, 24 24 - {"case-only diff is not a no-op", "foo", "Foo", "Foo", ""}, 25 25 - {"strip-git collides with current", "foo", "foo.git", "", "matches the current name"}, 18 18 + {"happy path", "foo", "", "bar", "bar", ""}, 19 19 + {"trims surrounding whitespace", "foo", "", " bar ", "bar", ""}, 20 20 + {"strips .git suffix", "foo", "", "bar.git", "bar", ""}, 21 21 + {"empty after trim", "foo", "", " ", "", "cannot be empty"}, 22 22 + {"raw empty", "foo", "", "", "", "cannot be empty"}, 23 23 + {"path traversal slash", "foo", "", "../bar", "", "invalid path"}, 24 24 + {"invalid character", "foo", "", "ba r", "", "alphanumeric"}, 25 25 + {"same name as current with non-TID rkey", "foo", "foo", "foo", "", "matches the current name"}, 26 26 + {"same name as current with TID rkey allowed", "foo", validTID, "foo", "foo", ""}, 27 27 + {"case-only diff is not a no-op", "foo", "", "Foo", "Foo", ""}, 28 28 + {"strip-git collides with current", "foo", "", "foo.git", "", "matches the current name"}, 26 29 } 27 30 for _, tc := range cases { 28 31 t.Run(tc.name, func(t *testing.T) { 29 29 - got, err := validateRenameInput(tc.currentName, tc.raw) 32 32 + got, err := validateRenameInput(tc.currentName, tc.currentRkey, tc.raw) 30 33 if tc.wantErrSub == "" { 31 34 if err != nil { 32 35 t.Fatalf("err = %v, want nil", err)

spindle/ingester.go

reviewed

This file has not been changed.

spindle/xrpc/add_secret.go

reviewed

This file has not been changed.

spindle/xrpc/list_secrets.go

reviewed

This file has not been changed.

spindle/xrpc/pipeline_cancel_pipeline.go

reviewed

This file has not been changed.

spindle/xrpc/remove_secret.go

reviewed

This file has not been changed.