Monorepo for Tangled tangled.org
859
fork

Configure Feed

Select the types of activity you want to include in your feed.

appview: ingester and indexers use repoDID #278

open opened by oyster.cafe targeting master from lt/repo-rename-by-rkey
Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:3fwecdnvtcscjnrx2p4n7alz/sh.tangled.repo.pull/3mjm6w2jh3u22
+7 -7
Interdiff #7 #8
appview/indexer/issues/indexer.go

This file has not been changed.

appview/indexer/issues/indexer_test.go

This file has not been changed.

appview/indexer/notifier.go

This file has not been changed.

appview/indexer/pulls/indexer.go

This file has not been changed.

appview/indexer/repos/indexer.go

This file has not been changed.

+7 -7
appview/ingester.go
··· 445 445 artifact := models.Artifact{ 446 446 Did: did, 447 447 Rkey: e.Commit.RKey, 448 - RepoDid: syntax.DID(repo.RepoDid), 448 + RepoAt: repo.RepoAt(), 449 449 Tag: plumbing.Hash(record.Tag), 450 450 CreatedAt: createdAt, 451 451 BlobCid: cid.Cid(record.Artifact.Ref), ··· 467 467 artifact := models.Artifact{ 468 468 Did: did, 469 469 Rkey: e.Commit.RKey, 470 - RepoAt: repo.RepoAt(), 470 + RepoDid: syntax.DID(repo.RepoDid), 471 471 Tag: plumbing.Hash(record.Tag), 472 472 CreatedAt: createdAt, 473 473 BlobCid: cid.Cid(record.Artifact.Ref), ··· 1014 1014 1015 1015 issue := models.IssueFromRecord(did, rkey, record) 1016 1016 1017 - if issue.RepoDid == "" { 1017 + if issue.RepoAt == "" { 1018 1018 return fmt.Errorf("issue record has no repo field") 1019 1019 } 1020 - if _, err := syntax.ParseDID(string(issue.RepoDid)); err != nil { 1021 - return fmt.Errorf("issue record repo field is not a valid DID: %w", err) 1022 - } 1023 1020 1024 1021 if err := i.Validator.ValidateIssue(&issue); err != nil { 1025 1022 return fmt.Errorf("failed to validate issue: %w", err) ··· 1039 1036 1040 1037 issue := models.IssueFromRecord(did, rkey, record) 1041 1038 1042 - if issue.RepoAt == "" { 1039 + if issue.RepoDid == "" { 1043 1040 return fmt.Errorf("issue record has no repo field") 1044 1041 } 1042 + if _, err := syntax.ParseDID(string(issue.RepoDid)); err != nil { 1043 + return fmt.Errorf("issue record repo field is not a valid DID: %w", err) 1044 + } 1045 1045 1046 1046 if err := i.Validator.ValidateIssue(&issue); err != nil { 1047 1047 return fmt.Errorf("failed to validate issue: %w", err)
appview/ingester_repo.go

This file has not been changed.

appview/ingester_repo_test.go

This file has not been changed.

History

9 rounds 0 comments
sign up or login to add to the discussion
1 commit
expand
appview: ingester and indexers use repoDID
merge conflicts detected
expand
  • api/tangled/cbor_gen.go:866
  • api/tangled/feedstar.go:5
  • api/tangled/gitrefUpdate.go:29
  • api/tangled/repocollaborator.go:19
  • api/tangled/repoissue.go:22
  • api/tangled/repopull.go:39
  • api/tangled/tangledrepo.go:24
  • cmd/cborgen/cborgen.go:17
  • knotserver/xrpc/merge.go:118
  • lexicons/feed/star.json:10
  • lexicons/git/refUpdate.json:11
  • lexicons/issue/issue.json:9
  • lexicons/pulls/pull.json:65
  • lexicons/repo/collaborator.json:11
  • lexicons/repo/repo.json:6
expand 0 comments
1 commit
expand
appview: ingester and indexers use repoDID
expand 0 comments
1 commit
expand
appview: ingester and indexers use repoDID
expand 0 comments
1 commit
expand
appview: ingester and indexers use repoDID
expand 0 comments
1 commit
expand
appview: ingester and indexers use repoDID
expand 0 comments
1 commit
expand
appview: ingester and indexers use repoDID
expand 0 comments
1 commit
expand
appview: ingester and indexers use repoDID
expand 0 comments
1 commit
expand
appview: ingester and indexers use repoDID
expand 0 comments
1 commit
expand
appview: ingester and indexers use repoDID
expand 0 comments