Monorepo for Tangled tangled.org
855
fork

Configure Feed

Select the types of activity you want to include in your feed.

appview,knotserver: validate git repo ownership according to knot #281

open opened by oyster.cafe targeting master from lt/repo-rename-by-rkey
Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:3fwecdnvtcscjnrx2p4n7alz/sh.tangled.repo.pull/3mjwlqwlv7f22
+4 -4
Interdiff #7 #8
api/tangled/repodescribeRepo.go

This file has not been changed.

+4 -4
appview/ingester.go
··· 1027 1027 return fmt.Errorf("failed to validate issue: %w", err) 1028 1028 } 1029 1029 1030 - if record.Repo != "" && !strings.HasPrefix(record.Repo, "did:") { 1031 - repo, repoErr := db.GetRepoByAtUri(i.Db, record.Repo) 1030 + if record.Repo != nil { 1031 + repo, repoErr := db.GetRepoByAtUri(i.Db, *record.Repo) 1032 1032 if repoErr == nil && repo.RepoDid != "" { 1033 1033 if enqErr := db.EnqueuePdsRecordMigration(ctx, i.Db, "add-repo-did", syntax.DID(did), syntax.NSID(tangled.RepoIssueNSID), syntax.RecordKey(e.Commit.RKey)); enqErr != nil { 1034 1034 l.Warn("failed to enqueue PDS rewrite for issue", "err", enqErr, "did", did, "repoDid", repo.RepoDid) ··· 1049 1049 return fmt.Errorf("failed to validate issue: %w", err) 1050 1050 } 1051 1051 1052 - if record.Repo != nil { 1053 - repo, repoErr := db.GetRepoByAtUri(i.Db, *record.Repo) 1052 + if record.Repo != "" && !strings.HasPrefix(record.Repo, "did:") { 1053 + repo, repoErr := db.GetRepoByAtUri(i.Db, record.Repo) 1054 1054 if repoErr == nil && repo.RepoDid != "" { 1055 1055 if enqErr := db.EnqueuePdsRecordMigration(ctx, i.Db, "add-repo-did", syntax.DID(did), syntax.NSID(tangled.RepoIssueNSID), syntax.RecordKey(e.Commit.RKey)); enqErr != nil { 1056 1056 l.Warn("failed to enqueue PDS rewrite for issue", "err", enqErr, "did", did, "repoDid", repo.RepoDid)
appview/ingester_repo.go

This file has not been changed.

appview/ingester_repo_test.go

This file has not been changed.

appview/pulls/comment.go

This file has not been changed.

appview/pulls/create.go

This patch was likely rebased, as context lines do not match.

appview/pulls/lifecycle.go

This file has not been changed.

appview/pulls/list.go

This file has not been changed.

appview/pulls/merge.go

This file has not been changed.

appview/pulls/resubmit.go

This file has not been changed.

appview/pulls/single.go

This patch was likely rebased, as context lines do not match.

appview/repoverify/verify.go

This file has not been changed.

appview/repoverify/verify_test.go

This file has not been changed.

appview/state/state.go

This file has not been changed.

knotserver/xrpc/repo_describe_repo.go

This file has not been changed.

knotserver/xrpc/repo_describe_repo_test.go

This file has not been changed.

knotserver/xrpc/xrpc.go

This file has not been changed.

lexicons/repo/describeRepo.json

This file has not been changed.

History

9 rounds 0 comments
sign up or login to add to the discussion
1 commit
expand
appview,knotserver: validate git repo ownership according to knot
merge conflicts detected
expand
  • api/tangled/cbor_gen.go:866
  • api/tangled/feedstar.go:5
  • api/tangled/gitrefUpdate.go:29
  • api/tangled/repocollaborator.go:19
  • api/tangled/repoissue.go:22
  • api/tangled/repopull.go:39
  • api/tangled/tangledrepo.go:24
  • cmd/cborgen/cborgen.go:17
  • knotserver/xrpc/merge.go:118
  • lexicons/feed/star.json:10
  • lexicons/git/refUpdate.json:11
  • lexicons/issue/issue.json:9
  • lexicons/pulls/pull.json:65
  • lexicons/repo/collaborator.json:11
  • lexicons/repo/repo.json:6
expand 0 comments
1 commit
expand
appview,knotserver: validate git repo ownership according to knot
expand 0 comments
1 commit
expand
appview,knotserver: validate git repo ownership according to knot
expand 0 comments
1 commit
expand
appview,knotserver: validate git repo ownership according to knot
expand 0 comments
1 commit
expand
appview,knotserver: validate git repo ownership according to knot
expand 0 comments
1 commit
expand
appview,knotserver: validate git repo ownership according to knot
expand 0 comments
1 commit
expand
appview,knotserver: validate git repo ownership according to knot
expand 0 comments
1 commit
expand
appview,knotserver: validate git repo ownership according to knot
expand 0 comments
1 commit
expand
appview,knotserver: validate git repo ownership according to knot
expand 0 comments