tangled.org / core
Monorepo for Tangled tangled.org
858
fork

Configure Feed

Select the types of activity you want to include in your feed.

appview: issues: filter issues by clicking a label #283

open opened by
nove-b.dev targeting master from nove-b.dev/tangled-core: href-issue-label

When contributing to a project, it's common to start by browsing issues with a label like "good-first-issue". Clicking a label to automatically filter issues by that label makes this workflow more convenient.

When a label is clicked, a query parameter is appended to the URL to filter the issue listing.

Closes #499

Labels

None yet.

assignee

None yet.

Participants 1
AT URI
at://did:plc:2atly2y5kfyjcj5zap6pv4wd/sh.tangled.repo.pull/3mkpenmah6d22
+2 -14
Interdiff #3 → #4
appview/issues/issues.go

This file has not been changed.

+2 -2
appview/pages/pages.go
··· 1151 1151 Page pagination.Page 1152 1152 FilterState string 1153 1153 FilterQuery string 1154 - BaseFilterQuery string 1155 1154 VouchRelationships map[syntax.DID]*models.VouchRelationship 1156 1155 } 1157 1156 ··· 1173 1172 Page pagination.Page 1174 1173 FilterState string 1175 1174 FilterQuery string 1175 + BaseFilterQuery string 1176 1176 VouchRelationships map[syntax.DID]*models.VouchRelationship 1177 1177 } 1178 1178 ··· 1285 1285 Active string 1286 1286 FilterState string 1287 1287 FilterQuery string 1288 - BaseFilterQuery string 1289 1288 Stacks []models.Stack 1290 1289 Pipelines map[string]models.Pipeline 1291 1290 LabelDefs map[string]*models.LabelDefinition ··· 1337 1336 Active string 1338 1337 FilterState string 1339 1338 FilterQuery string 1339 + BaseFilterQuery string 1340 1340 Stacks []models.Stack 1341 1341 Pipelines map[string]models.Pipeline 1342 1342 LabelDefs map[string]*models.LabelDefinition
appview/pages/templates/labels/fragments/label.html

This file has not been changed.

appview/pages/templates/repo/issues/fragments/issueListing.html

This file has not been changed.

appview/pages/templates/repo/issues/issues.html

This file has not been changed.

appview/pages/templates/repo/pulls/pulls.html

This file has not been changed.

-12
appview/pulls/pulls.go
··· 807 807 } 808 808 } 809 809 810 - baseFilterParts := make([]string, 0, len(query.Items())) 811 - for _, item := range query.Items() { 812 - if item.Kind == searchquery.KindTagValue { 813 - if item.Key == "label" || !searchquery.KnownTags[item.Key] { 814 - continue 815 - } 816 - } 817 - baseFilterParts = append(baseFilterParts, item.Raw) 818 - } 819 - baseFilterQuery := strings.Join(baseFilterParts, " ") 820 - 821 810 err = s.pages.RepoPulls(w, pages.RepoPullsParams{ 822 811 LoggedInUser: s.oauth.GetMultiAccountUser(r), 823 812 RepoInfo: repoInfo, ··· 825 814 LabelDefs: defs, 826 815 FilterState: filterState, 827 816 FilterQuery: query.String(), 828 - BaseFilterQuery: baseFilterQuery, 829 817 Stacks: stacks, 830 818 Pipelines: m, 831 819 Page: page,

History

5 rounds 0 comments
sign up or login to add to the discussion
nove-b.dev submitted #4
diff
1 commit
expand
e70265fa
appview: issues: filter issues by label on click
merge conflicts detected
expand
  • appview/issues/issues.go:7
  • appview/pages/pages.go:1172
  • appview/pages/templates/labels/fragments/label.html:2
  • appview/pages/templates/repo/issues/fragments/issueListing.html:46
  • appview/pages/templates/repo/issues/issues.html:71
  • appview/pages/templates/repo/pulls/pulls.html:111
expand 0 comments
nove-b.dev submitted #3
diff interdiff
1 commit
expand
e208258a
appview: issues: filter issues by label on click
expand 0 comments
nove-b.dev submitted #2
diff interdiff
1 commit
expand
fc127040
appview: issues: filter issues by label on click
expand 0 comments
nove-b.dev submitted #1
diff interdiff
1 commit
expand
f3fa543b
appview: issues: filter issues by label on click
expand 0 comments
nove-b.dev submitted #0
diff
1 commit
expand
6aaf487d
appview: issues: filter issues by label on click
expand 0 comments