Reworks how the PR discussion thread filters review comments.
There are two independent filters:
- show general (unpinned) comments
- show comments pinned to revisions outside the selected range
Silently deciding when to show which is bad and unintuitive, so give filter menu on discussion header with clear filter options.
Defaults based on view:
| View | General comments | Pins outside the selection |
|---|---|---|
| Diff, full range | shown | hidden |
| Diff, narrowed | hidden | hidden |
| Interdiff, all | hidden | hidden |
| Interdiff, one change | hidden | hidden |
Both filters reset when the selection changes. A filter button in the discussion header lets user override them, and it's highlighted while either one is on.
Also give clearer highlight for unpinned comments.
Preview:
