web: variety of fixups #4687

Merged

oppi.li 1w ago

targeting master from op/upqszzkkttwx

Merged opened by and assigned to

oppi.li 1w ago targeting master from op/upqszzkkttwx

Commits 0

Could not load commits.

Comments

v0 1w ago

boltman.tngl.sh 9681193b 1w ago

Can we have collapse button after expansion? I somewhat agree that collapsing a list back makes less sense when they already reached README, but I think this kind of layout change should be reversible without full page refresh.

boltless.me d4c4023f 1w ago

ngl, I liked old design more. There is much more information we can show in signature hovercard, like why it's partially-verified or unverified or trust-level information used by codeberg.

Same goes for commit-id itself too. There is more stuffs we can put there related to commit-id. See #670 for context.

v1 1w ago

oppi.li 1w ago

i don't think these should be separate elements with hovercards of their own, rather, hovering over the new chip could show all of these at once. that being said, i don't think hiding functionality behind hovercards is a good pattern, we should limit that sort of design as much as possible.

boltless.me 1w ago

agreed on we should avoid hiding features behind hovercards and dropdowns, but I don' think it changes that much in this case, rather, I think merging signature sign & commit hash makes that situation worse.

Regardless of this change, users should still have to hover on commit ID to learn about available actions and hidden informations. And by merging signature mark and commit hash, it becomes more confusing because that UI element is doing two different tasks 1) show commit ID and relevant action 2) show signature verification state.

Because it's one element with two data squashed into one, we will have to hide relevant informations instead of exposing them. For example, we will have to put "Unverified" case (when signature exists but not verified) inside the hovercard and not exposed like GitHub.

We also get at least 3 different components to render short hash throughout our UI now.

shorthash chip in commit list
shorthash chip in PR commit list
shorthash chip in pinned PR review comments

But we will probably not put that green sha chip everywhere.

oppi.li 1w ago

thats alright, we will take some of these additional functionality back to the drawing board with @eti.tf (we don't need to stuff every page with all the functionality available!).

Versions