Summary#
- Replace 5
log.Println/log.Printfcalls inappview/repo/feed.gowithrp.logger.Errorusing structured key-value pairs. - Remove unused
"log"import — the Repo struct already has a*slog.Logger.
+5
-6
Diff
round #0
+5
-6
appview/repo/feed.go
+5
-6
appview/repo/feed.go
···
4
4
"context"
5
5
"encoding/json"
6
6
"fmt"
7
-
"log"
8
7
"net/http"
9
8
"slices"
10
9
"strings"
···
114
113
commitItems, err := rp.createCommitItems(ctx, repo, ownerSlashRepo)
115
114
if err != nil {
116
115
// Soft failure: log error and continue with partial feed
117
-
log.Printf("failed to fetch commits for feed: %v", err)
116
+
rp.logger.Error("failed to fetch commits for feed", "err", err)
118
117
} else {
119
118
feed.Items = append(feed.Items, commitItems...)
120
119
}
···
125
124
tagItems, err := rp.createTagItems(ctx, repo, ownerSlashRepo)
126
125
if err != nil {
127
126
// Soft failure: log error and continue with partial feed
128
-
log.Printf("failed to fetch tags for feed: %v", err)
127
+
rp.logger.Error("failed to fetch tags for feed", "err", err)
129
128
} else {
130
129
feed.Items = append(feed.Items, tagItems...)
131
130
}
···
308
307
func (rp *Repo) AtomFeed(w http.ResponseWriter, r *http.Request) {
309
308
f, err := rp.repoResolver.Resolve(r)
310
309
if err != nil {
311
-
log.Println("failed to fully resolve repo:", err)
310
+
rp.logger.Error("failed to fully resolve repo", "err", err)
312
311
return
313
312
}
314
313
repoOwnerId, ok := r.Context().Value("resolvedId").(identity.Identity)
315
314
if !ok || repoOwnerId.Handle.IsInvalidHandle() {
316
-
log.Println("failed to get resolved repo owner id")
315
+
rp.logger.Error("failed to get resolved repo owner id")
317
316
return
318
317
}
319
318
ownerSlashRepo := repoOwnerId.Handle.String() + "/" + f.Name
···
321
320
opts := parseFeedOpts(r)
322
321
feed, err := rp.getRepoFeed(r.Context(), f, ownerSlashRepo, opts)
323
322
if err != nil {
324
-
log.Println("failed to get repo feed:", err)
323
+
rp.logger.Error("failed to get repo feed", "err", err)
325
324
rp.pages.Error500(w)
326
325
return
327
326
}
History
1 round
0 comments
matias.tngl.sh
submitted
#0
1 commit
expand
collapse
appview/repo: replace log.Printf/Println with structured logging in feed.go
Signed-off-by: Matías Insaurralde <matias@insaurral.de>
merge conflicts detected
expand
collapse
expand
collapse
- appview/repo/feed.go:4