tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/damon/sysfs: do not ignore callback's return value in damon_sysfs_damon_call()

The callback return value is ignored in damon_sysfs_damon_call(), which
means that it is not possible to detect invalid user input when writing
commands such as 'commit' to
/sys/kernel/mm/damon/admin/kdamonds/<K>/state. Fix it.

Link: https://lkml.kernel.org/r/20250920132546.5822-1-akinobu.mita@gmail.com
Fixes: f64539dcdb87 ("mm/damon/sysfs: use damon_call() for update_schemes_stats")
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org> [6.14+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Akinobu Mita and committed by
Andrew Morton 06195ee9 87e1c7c9

+3 -1
+3 -1
mm/damon/sysfs.c
··· 1592 1592 struct damon_sysfs_kdamond *kdamond) 1593 1593 { 1594 1594 struct damon_call_control call_control = {}; 1595 + int err; 1595 1596 1596 1597 if (!kdamond->damon_ctx) 1597 1598 return -EINVAL; 1598 1599 call_control.fn = fn; 1599 1600 call_control.data = kdamond; 1600 - return damon_call(kdamond->damon_ctx, &call_control); 1601 + err = damon_call(kdamond->damon_ctx, &call_control); 1602 + return err ? err : call_control.return_code; 1601 1603 } 1602 1604 1603 1605 struct damon_sysfs_schemes_walk_data {