Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

dql: Fix dql->limit value when reset.

Executing dql_reset after setting a non-zero value for limit_min can
lead to an unreasonable situation where dql->limit is less than
dql->limit_min.

For instance, after setting
/sys/class/net/eth*/queues/tx-0/byte_queue_limits/limit_min,
an ifconfig down/up operation might cause the ethernet driver to call
netdev_tx_reset_queue, which in turn invokes dql_reset.

In this case, dql->limit is reset to 0 while dql->limit_min remains
non-zero value, which is unexpected. The limit should always be
greater than or equal to limit_min.

Signed-off-by: Jing Su <jingsusu@didiglobal.com>
Link: https://patch.msgid.link/Z9qHD1s/NEuQBdgH@pilot-ThinkCentre-M930t-N000
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Jing Su and committed by
Jakub Kicinski
3a17f23f 45e36a8e

+1 -1
+1 -1
lib/dynamic_queue_limits.c
··· 190 190 void dql_reset(struct dql *dql) 191 191 { 192 192 /* Reset all dynamic values */ 193 - dql->limit = 0; 193 + dql->limit = dql->min_limit; 194 194 dql->num_queued = 0; 195 195 dql->num_completed = 0; 196 196 dql->last_obj_cnt = 0;