tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: freescale: imx8qm-hsio: fix NULL pointer dereference

During the probe the refclk_pad pointer is set to NULL if the
'fsl,refclk-pad-mode' property is not defined in the devicetree node. But
in imx_hsio_configure_clk_pad() this pointer is unconditionally used which
could result in a NULL pointer dereference. So check the pointer before to
use it.

Fixes: 82c56b6dd24f ("phy: freescale: imx8qm-hsio: Add i.MX8QM HSIO PHY driver support")
Signed-off-by: Thomas Richard <thomas.richard@bootlin.com>
Reviewed-by: Richard Zhu <hongxing.zhu@nxp.com>
Link: https://patch.msgid.link/20260114-phy-fsl-imx8qm-hsio-fix-null-pointer-dereference-v1-1-730e941be464@bootlin.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Thomas Richard and committed by
Vinod Koul 4dd5d4c0 e2ce9134

+1 -1
+1 -1
drivers/phy/freescale/phy-fsl-imx8qm-hsio.c
··· 251 251 struct imx_hsio_lane *lane = phy_get_drvdata(phy); 252 252 struct imx_hsio_priv *priv = lane->priv; 253 253 254 - if (strncmp(priv->refclk_pad, "output", 6) == 0) { 254 + if (priv->refclk_pad && strncmp(priv->refclk_pad, "output", 6) == 0) { 255 255 pll = true; 256 256 regmap_update_bits(priv->misc, HSIO_CTRL0, 257 257 HSIO_IOB_A_0_TXOE | HSIO_IOB_A_0_M1M0_MASK,