Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
gpu: nova-core: remove redundant `.as_ref()` for `dev_*` print
This is now handled by the macro itself.
Signed-off-by: Gary Guo <gary@garyguo.net>
Link: https://patch.msgid.link/20260123175854.176735-7-gary@kernel.org
Signed-off-by: Danilo Krummrich <dakr@kernel.org>
authored by
Gary Guo
and committed by
Danilo Krummrich
8d1a65c2
ef2964f1
+10
-28
+1
-1
drivers/gpu/nova-core/driver.rs
+1
-1
drivers/gpu/nova-core/driver.rs
···
70
70
71
71
fn probe(pdev: &pci::Device<Core>, _info: &Self::IdInfo) -> impl PinInit<Self, Error> {
72
72
pin_init::pin_init_scope(move || {
73
-
dev_dbg!(pdev.as_ref(), "Probe Nova Core GPU driver.\n");
73
+
dev_dbg!(pdev, "Probe Nova Core GPU driver.\n");
74
74
75
75
pdev.enable_device_mem()?;
76
76
pdev.set_master();
+2
-2
drivers/gpu/nova-core/gpu.rs
+2
-2
drivers/gpu/nova-core/gpu.rs
···
262
262
) -> impl PinInit<Self, Error> + 'a {
263
263
try_pin_init!(Self {
264
264
spec: Spec::new(pdev.as_ref(), bar).inspect(|spec| {
265
-
dev_info!(pdev.as_ref(),"NVIDIA ({})\n", spec);
265
+
dev_info!(pdev,"NVIDIA ({})\n", spec);
266
266
})?,
267
267
268
268
// We must wait for GFW_BOOT completion before doing any significant setup on the GPU.
269
269
_: {
270
270
gfw::wait_gfw_boot_completion(bar)
271
-
.inspect_err(|_| dev_err!(pdev.as_ref(), "GFW boot did not complete\n"))?;
271
+
.inspect_err(|_| dev_err!(pdev, "GFW boot did not complete\n"))?;
272
272
},
273
273
274
274
sysmem_flush: SysmemFlush::register(pdev.as_ref(), bar, spec.chipset)?,
+7
-25
drivers/gpu/nova-core/gsp/boot.rs
+7
-25
drivers/gpu/nova-core/gsp/boot.rs
···
170
170
Some(libos_handle as u32),
171
171
Some((libos_handle >> 32) as u32),
172
172
)?;
173
-
dev_dbg!(
174
-
pdev.as_ref(),
175
-
"GSP MBOX0: {:#x}, MBOX1: {:#x}\n",
176
-
mbox0,
177
-
mbox1
178
-
);
173
+
dev_dbg!(pdev, "GSP MBOX0: {:#x}, MBOX1: {:#x}\n", mbox0, mbox1);
179
174
180
175
dev_dbg!(
181
-
pdev.as_ref(),
176
+
pdev,
182
177
"Using SEC2 to load and run the booter_load firmware...\n"
183
178
);
184
179
···
185
190
Some(wpr_handle as u32),
186
191
Some((wpr_handle >> 32) as u32),
187
192
)?;
188
-
dev_dbg!(
189
-
pdev.as_ref(),
190
-
"SEC2 MBOX0: {:#x}, MBOX1{:#x}\n",
191
-
mbox0,
192
-
mbox1
193
-
);
193
+
dev_dbg!(pdev, "SEC2 MBOX0: {:#x}, MBOX1{:#x}\n", mbox0, mbox1);
194
194
195
195
if mbox0 != 0 {
196
-
dev_err!(
197
-
pdev.as_ref(),
198
-
"Booter-load failed with error {:#x}\n",
199
-
mbox0
200
-
);
196
+
dev_err!(pdev, "Booter-load failed with error {:#x}\n", mbox0);
201
197
return Err(ENODEV);
202
198
}
203
199
···
202
216
Delta::from_secs(5),
203
217
)?;
204
218
205
-
dev_dbg!(
206
-
pdev.as_ref(),
207
-
"RISC-V active? {}\n",
208
-
gsp_falcon.is_riscv_active(bar),
209
-
);
219
+
dev_dbg!(pdev, "RISC-V active? {}\n", gsp_falcon.is_riscv_active(bar),);
210
220
211
221
// Create and run the GSP sequencer.
212
222
let seq_params = GspSequencerParams {
···
221
239
// Obtain and display basic GPU information.
222
240
let info = commands::get_gsp_info(&mut self.cmdq, bar)?;
223
241
match info.gpu_name() {
224
-
Ok(name) => dev_info!(pdev.as_ref(), "GPU name: {}\n", name),
225
-
Err(e) => dev_warn!(pdev.as_ref(), "GPU name unavailable: {:?}\n", e),
242
+
Ok(name) => dev_info!(pdev, "GPU name: {}\n", name),
243
+
Err(e) => dev_warn!(pdev, "GPU name unavailable: {:?}\n", e),
226
244
}
227
245
228
246
Ok(())