tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/sprd: move to devm_platform_ioremap_resource() usage

Replace platform_get_resource + devm_ioremap
with just devm_platform_ioremap_resource()

Used Coccinelle to do this change. SmPl patch:
@rule_2@
identifier res;
expression ioremap;
identifier pdev;
@@
-struct resource *res;
...
-res = platform_get_resource(pdev,...);
<...
-if (!res) {
-...
-}
...>
-ioremap = devm_ioremap(...);
+ioremap = devm_platform_ioremap_resource(pdev,0);

v2: Address the return handling properly since
the new API returns error pointers and not NULL.

Cc: Chunyan Zhang <zhang.lyra@gmail.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Anusha Srivatsa <asrivats@redhat.com>
Reviewed-by: Chunyan Zhang <zhang.lyra@gmail.com>(v1)
Reviewed-by: Maxime Ripard <mripard@kernel.org>(v1)
Link: https://patchwork.freedesktop.org/patch/640854/?series=144073&rev=5

authored by

Anusha Srivatsa and committed by
Anusha Srivatsa 92b8f062 3282422b

+6 -20
+3 -10
drivers/gpu/drm/sprd/sprd_dpu.c
··· 784 784 { 785 785 struct platform_device *pdev = to_platform_device(dev); 786 786 struct dpu_context *ctx = &dpu->ctx; 787 - struct resource *res; 788 787 int ret; 789 788 790 - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); 791 - if (!res) { 792 - dev_err(dev, "failed to get I/O resource\n"); 793 - return -EINVAL; 794 - } 795 - 796 - ctx->base = devm_ioremap(dev, res->start, resource_size(res)); 797 - if (!ctx->base) { 789 + ctx->base = devm_platform_ioremap_resource(pdev, 0); 790 + if (IS_ERR(ctx->base)) { 798 791 dev_err(dev, "failed to map dpu registers\n"); 799 - return -EFAULT; 792 + return PTR_ERR(ctx->base); 800 793 } 801 794 802 795 ctx->irq = platform_get_irq(pdev, 0);
+3 -10
drivers/gpu/drm/sprd/sprd_dsi.c
··· 901 901 { 902 902 struct platform_device *pdev = to_platform_device(dev); 903 903 struct dsi_context *ctx = &dsi->ctx; 904 - struct resource *res; 905 904 906 - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); 907 - if (!res) { 908 - dev_err(dev, "failed to get I/O resource\n"); 909 - return -EINVAL; 910 - } 911 - 912 - ctx->base = devm_ioremap(dev, res->start, resource_size(res)); 913 - if (!ctx->base) { 905 + ctx->base = devm_platform_ioremap_resource(pdev, 0); 906 + if (IS_ERR(ctx->base)) { 914 907 drm_err(dsi->drm, "failed to map dsi host registers\n"); 915 - return -ENXIO; 908 + return PTR_ERR(ctx->base); 916 909 } 917 910 918 911 ctx->regmap = devm_regmap_init(dev, &regmap_tst_io, dsi, &byte_config);