tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

gpu: nova-core: falcon: remove FalconFirmware's dependency on FalconDmaLoadable

Not all firmware is necessarily loaded by DMA. Remove the requirement
for `FalconFirmware` to implement `FalconDmaLoadable`, and adapt
`Falcon`'s methods constraints accordingly.

Reviewed-by: Eliot Courtney <ecourtney@nvidia.com>
Acked-by: Danilo Krummrich <dakr@kernel.org>
Link: https://patch.msgid.link/20260306-turing_prep-v11-4-8f0042c5d026@nvidia.com
Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>

Alexandre Courbot 99d451cb 8a623869

+3 -3
+3 -3
drivers/gpu/nova-core/falcon.rs
··· 378 378 /// Trait for a falcon firmware. 379 379 /// 380 380 /// A falcon firmware can be loaded on a given engine. 381 - pub(crate) trait FalconFirmware: FalconDmaLoadable { 381 + pub(crate) trait FalconFirmware { 382 382 /// Engine on which this firmware is to be loaded. 383 383 type Target: FalconEngine; 384 384 } ··· 521 521 } 522 522 523 523 /// Perform a DMA load into `IMEM` and `DMEM` of `fw`, and prepare the falcon to run it. 524 - fn dma_load<F: FalconFirmware<Target = E>>( 524 + fn dma_load<F: FalconFirmware<Target = E> + FalconDmaLoadable>( 525 525 &self, 526 526 dev: &Device<device::Bound>, 527 527 bar: &Bar0, ··· 660 660 } 661 661 662 662 // Load a firmware image into Falcon memory 663 - pub(crate) fn load<F: FalconFirmware<Target = E>>( 663 + pub(crate) fn load<F: FalconFirmware<Target = E> + FalconDmaLoadable>( 664 664 &self, 665 665 dev: &Device<device::Bound>, 666 666 bar: &Bar0,