tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

platform-msi: Add msi_remove_device_irq_domain() in platform_device_msi_free_irqs_all()

platform_device_msi_init_and_alloc_irqs() performs two tasks: allocating
the MSI domain for a platform device, and allocate a number of MSIs in that
domain.

platform_device_msi_free_irqs_all() only frees the MSIs, and leaves the MSI
domain alive.

Given that platform_device_msi_init_and_alloc_irqs() is the sole tool a
platform device has to allocate platform MSIs, it makes sense for
platform_device_msi_free_irqs_all() to teardown the MSI domain at the same
time as the MSIs.

This avoids warnings and unexpected behaviours when a driver repeatedly
allocates and frees MSIs.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/all/20250414-ep-msi-v18-1-f69b49917464@nxp.com

authored by

Frank Li and committed by
Thomas Gleixner 9a958e1f 0af2f6be

+1
+1
drivers/base/platform-msi.c
··· 95 95 void platform_device_msi_free_irqs_all(struct device *dev) 96 96 { 97 97 msi_domain_free_irqs_all(dev, MSI_DEFAULT_DOMAIN); 98 + msi_remove_device_irq_domain(dev, MSI_DEFAULT_DOMAIN); 98 99 } 99 100 EXPORT_SYMBOL_GPL(platform_device_msi_free_irqs_all);