tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Improve consistency of '#error' directive messages

Remove the use of contractions and use proper punctuation in #error
directive messages that discourage the direct inclusion of header files.

Link: https://lkml.kernel.org/r/20241105032231.28833-1-natanielfarzan@gmail.com
Signed-off-by: Nataniel Farzan <natanielfarzan@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

Nataniel Farzan and committed by
Andrew Morton a7306f3c adc77b19

+19 -19
+1 -1
arch/alpha/include/asm/spinlock_types.h
··· 3 3 #define _ALPHA_SPINLOCK_TYPES_H 4 4 5 5 #ifndef __LINUX_SPINLOCK_TYPES_RAW_H 6 - # error "please don't include this file directly" 6 + # error "Please do not include this file directly." 7 7 #endif 8 8 9 9 typedef struct {
+1 -1
arch/arm/include/asm/spinlock_types.h
··· 3 3 #define __ASM_SPINLOCK_TYPES_H 4 4 5 5 #ifndef __LINUX_SPINLOCK_TYPES_RAW_H 6 - # error "please don't include this file directly" 6 + # error "Please do not include this file directly." 7 7 #endif 8 8 9 9 #define TICKET_SHIFT 16
+1 -1
arch/arm64/include/asm/spinlock_types.h
··· 6 6 #define __ASM_SPINLOCK_TYPES_H 7 7 8 8 #if !defined(__LINUX_SPINLOCK_TYPES_RAW_H) && !defined(__ASM_SPINLOCK_H) 9 - # error "please don't include this file directly" 9 + # error "Please do not include this file directly." 10 10 #endif 11 11 12 12 #include <asm-generic/qspinlock_types.h>
+1 -1
arch/hexagon/include/asm/spinlock_types.h
··· 9 9 #define _ASM_SPINLOCK_TYPES_H 10 10 11 11 #ifndef __LINUX_SPINLOCK_TYPES_RAW_H 12 - # error "please don't include this file directly" 12 + # error "Please do not include this file directly." 13 13 #endif 14 14 15 15 typedef struct {
+1 -1
arch/powerpc/include/asm/simple_spinlock_types.h
··· 3 3 #define _ASM_POWERPC_SIMPLE_SPINLOCK_TYPES_H 4 4 5 5 #ifndef __LINUX_SPINLOCK_TYPES_RAW_H 6 - # error "please don't include this file directly" 6 + # error "Please do not include this file directly." 7 7 #endif 8 8 9 9 typedef struct {
+1 -1
arch/powerpc/include/asm/spinlock_types.h
··· 3 3 #define _ASM_POWERPC_SPINLOCK_TYPES_H 4 4 5 5 #ifndef __LINUX_SPINLOCK_TYPES_RAW_H 6 - # error "please don't include this file directly" 6 + # error "Please do not include this file directly." 7 7 #endif 8 8 9 9 #ifdef CONFIG_PPC_QUEUED_SPINLOCKS
+1 -1
arch/s390/include/asm/spinlock_types.h
··· 3 3 #define __ASM_SPINLOCK_TYPES_H 4 4 5 5 #ifndef __LINUX_SPINLOCK_TYPES_RAW_H 6 - # error "please don't include this file directly" 6 + # error "Please do not include this file directly." 7 7 #endif 8 8 9 9 typedef struct {
+1 -1
arch/sh/include/asm/spinlock_types.h
··· 3 3 #define __ASM_SH_SPINLOCK_TYPES_H 4 4 5 5 #ifndef __LINUX_SPINLOCK_TYPES_RAW_H 6 - # error "please don't include this file directly" 6 + # error "Please do not include this file directly." 7 7 #endif 8 8 9 9 typedef struct {
+1 -1
arch/xtensa/include/asm/spinlock_types.h
··· 3 3 #define __ASM_SPINLOCK_TYPES_H 4 4 5 5 #if !defined(__LINUX_SPINLOCK_TYPES_RAW_H) && !defined(__ASM_SPINLOCK_H) 6 - # error "please don't include this file directly" 6 + # error "Please do not include this file directly." 7 7 #endif 8 8 9 9 #include <asm-generic/qspinlock_types.h>
+1 -1
include/acpi/platform/aclinux.h
··· 15 15 /* ACPICA external files should not include ACPICA headers directly. */ 16 16 17 17 #if !defined(BUILDING_ACPICA) && !defined(_LINUX_ACPI_H) 18 - #error "Please don't include <acpi/acpi.h> directly, include <linux/acpi.h> instead." 18 + #error "Please do not include <acpi/acpi.h> directly, include <linux/acpi.h> instead." 19 19 #endif 20 20 21 21 #endif
+1 -1
include/linux/compiler-clang.h
··· 1 1 /* SPDX-License-Identifier: GPL-2.0 */ 2 2 #ifndef __LINUX_COMPILER_TYPES_H 3 - #error "Please don't include <linux/compiler-clang.h> directly, include <linux/compiler.h> instead." 3 + #error "Please do not include <linux/compiler-clang.h> directly, include <linux/compiler.h> instead." 4 4 #endif 5 5 6 6 /* Compiler specific definitions for Clang compiler */
+1 -1
include/linux/compiler-gcc.h
··· 1 1 /* SPDX-License-Identifier: GPL-2.0 */ 2 2 #ifndef __LINUX_COMPILER_TYPES_H 3 - #error "Please don't include <linux/compiler-gcc.h> directly, include <linux/compiler.h> instead." 3 + #error "Please do not include <linux/compiler-gcc.h> directly, include <linux/compiler.h> instead." 4 4 #endif 5 5 6 6 /*
+1 -1
include/linux/pm_wakeup.h
··· 10 10 #define _LINUX_PM_WAKEUP_H 11 11 12 12 #ifndef _DEVICE_H_ 13 - # error "please don't include this file directly" 13 + # error "Please do not include this file directly." 14 14 #endif 15 15 16 16 #include <linux/types.h>
+1 -1
include/linux/rwlock.h
··· 2 2 #define __LINUX_RWLOCK_H 3 3 4 4 #ifndef __LINUX_INSIDE_SPINLOCK_H 5 - # error "please don't include this file directly" 5 + # error "Please do not include this file directly." 6 6 #endif 7 7 8 8 /*
+1 -1
include/linux/rwlock_api_smp.h
··· 2 2 #define __LINUX_RWLOCK_API_SMP_H 3 3 4 4 #ifndef __LINUX_SPINLOCK_API_SMP_H 5 - # error "please don't include this file directly" 5 + # error "Please do not include this file directly." 6 6 #endif 7 7 8 8 /*
+1 -1
include/linux/spinlock_api_smp.h
··· 2 2 #define __LINUX_SPINLOCK_API_SMP_H 3 3 4 4 #ifndef __LINUX_INSIDE_SPINLOCK_H 5 - # error "please don't include this file directly" 5 + # error "Please do not include this file directly." 6 6 #endif 7 7 8 8 /*
+1 -1
include/linux/spinlock_types_up.h
··· 2 2 #define __LINUX_SPINLOCK_TYPES_UP_H 3 3 4 4 #ifndef __LINUX_SPINLOCK_TYPES_RAW_H 5 - # error "please don't include this file directly" 5 + # error "Please do not include this file directly." 6 6 #endif 7 7 8 8 /*
+1 -1
include/linux/spinlock_up.h
··· 2 2 #define __LINUX_SPINLOCK_UP_H 3 3 4 4 #ifndef __LINUX_INSIDE_SPINLOCK_H 5 - # error "please don't include this file directly" 5 + # error "Please do not include this file directly." 6 6 #endif 7 7 8 8 #include <asm/processor.h> /* for cpu_relax() */
+1 -1
tools/include/linux/compiler-gcc.h
··· 1 1 /* SPDX-License-Identifier: GPL-2.0 */ 2 2 #ifndef _TOOLS_LINUX_COMPILER_H_ 3 - #error "Please don't include <linux/compiler-gcc.h> directly, include <linux/compiler.h> instead." 3 + #error "Please do not include <linux/compiler-gcc.h> directly, include <linux/compiler.h> instead." 4 4 #endif 5 5 6 6 /*