Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

iio: frequency: ad9523: use octal permissions

The driver currently defines device attributes using symbolic permission
flags (S_IRUGO and S_IWUSR). Update these to use octal permissions (0444
and 0200) to resolve checkpatch warnings.

Signed-off-by: Bhargav Joshi <rougueprince47@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

authored by

Bhargav Joshi and committed by
Jonathan Cameron
dfe5e8fb 787c9a9c

+20 -40
+20 -40
drivers/iio/frequency/ad9523.c
··· 558 558 return ret; 559 559 } 560 560 561 - static IIO_DEVICE_ATTR(pll1_locked, S_IRUGO, 562 - ad9523_show, 563 - NULL, 564 - AD9523_STAT_PLL1_LD); 561 + static IIO_DEVICE_ATTR(pll1_locked, 0444, ad9523_show, NULL, 562 + AD9523_STAT_PLL1_LD); 565 563 566 - static IIO_DEVICE_ATTR(pll2_locked, S_IRUGO, 567 - ad9523_show, 568 - NULL, 569 - AD9523_STAT_PLL2_LD); 564 + static IIO_DEVICE_ATTR(pll2_locked, 0444, ad9523_show, NULL, 565 + AD9523_STAT_PLL2_LD); 570 566 571 - static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, S_IRUGO, 572 - ad9523_show, 573 - NULL, 574 - AD9523_STAT_REFA); 567 + static IIO_DEVICE_ATTR(pll1_reference_clk_a_present, 0444, ad9523_show, NULL, 568 + AD9523_STAT_REFA); 575 569 576 - static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, S_IRUGO, 577 - ad9523_show, 578 - NULL, 579 - AD9523_STAT_REFB); 570 + static IIO_DEVICE_ATTR(pll1_reference_clk_b_present, 0444, ad9523_show, NULL, 571 + AD9523_STAT_REFB); 580 572 581 - static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, S_IRUGO, 582 - ad9523_show, 583 - NULL, 584 - AD9523_STAT_REF_TEST); 573 + static IIO_DEVICE_ATTR(pll1_reference_clk_test_present, 0444, ad9523_show, NULL, 574 + AD9523_STAT_REF_TEST); 585 575 586 - static IIO_DEVICE_ATTR(vcxo_clk_present, S_IRUGO, 587 - ad9523_show, 588 - NULL, 589 - AD9523_STAT_VCXO); 576 + static IIO_DEVICE_ATTR(vcxo_clk_present, 0444, ad9523_show, NULL, 577 + AD9523_STAT_VCXO); 590 578 591 - static IIO_DEVICE_ATTR(pll2_feedback_clk_present, S_IRUGO, 592 - ad9523_show, 593 - NULL, 594 - AD9523_STAT_PLL2_FB_CLK); 579 + static IIO_DEVICE_ATTR(pll2_feedback_clk_present, 0444, ad9523_show, NULL, 580 + AD9523_STAT_PLL2_FB_CLK); 595 581 596 - static IIO_DEVICE_ATTR(pll2_reference_clk_present, S_IRUGO, 597 - ad9523_show, 598 - NULL, 599 - AD9523_STAT_PLL2_REF_CLK); 582 + static IIO_DEVICE_ATTR(pll2_reference_clk_present, 0444, ad9523_show, NULL, 583 + AD9523_STAT_PLL2_REF_CLK); 600 584 601 - static IIO_DEVICE_ATTR(sync_dividers, S_IWUSR, 602 - NULL, 603 - ad9523_store, 604 - AD9523_SYNC); 585 + static IIO_DEVICE_ATTR(sync_dividers, 0200, NULL, ad9523_store, 586 + AD9523_SYNC); 605 587 606 - static IIO_DEVICE_ATTR(store_eeprom, S_IWUSR, 607 - NULL, 608 - ad9523_store, 609 - AD9523_EEPROM); 588 + static IIO_DEVICE_ATTR(store_eeprom, 0200, NULL, ad9523_store, 589 + AD9523_EEPROM); 610 590 611 591 static struct attribute *ad9523_attributes[] = { 612 592 &iio_dev_attr_sync_dividers.dev_attr.attr,