tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

[PATCH] b44: change comment about irq mask register

Through some experimentation with the similarly built bcm43xx I came to
the conclusion that if the hw/firmware sets a bit in the interrupt
register, an interrupt will only be raised if that bit is included in
the interrupt mask. Hence, the interrupt mask is more like an interrupt
control mask.

This patch changes the comment to reflect that.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

authored by

Johannes Berg and committed by
Jeff Garzik e78181fe c836b771

+3 -2
+3 -2
drivers/net/b44.c
··· 908 908 istat = br32(bp, B44_ISTAT); 909 909 imask = br32(bp, B44_IMASK); 910 910 911 - /* ??? What the fuck is the purpose of the interrupt mask 912 - * ??? register if we have to mask it out by hand anyways? 911 + /* The interrupt mask register controls which interrupt bits 912 + * will actually raise an interrupt to the CPU when set by hw/firmware, 913 + * but doesn't mask off the bits. 913 914 */ 914 915 istat &= imask; 915 916 if (istat) {