tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mtd: ssfdc: One function call less in ssfdcr_add_mtd() after error detection

The kfree() function was called in one case by
the ssfdcr_add_mtd() function during error handling
even if the passed data structure member contained a null pointer.
This issue was detected by using the Coccinelle software.

Thus use another label.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/56d92e42-db9e-4767-bcb1-9686bdf34a03@web.de

authored by

Markus Elfring and committed by
Miquel Raynal e8b7d11c 8d55a90b

+2 -1
+2 -1
drivers/mtd/ssfdc.c
··· 332 332 kmalloc_array(ssfdc->map_len, 333 333 sizeof(ssfdc->logic_block_map[0]), GFP_KERNEL); 334 334 if (!ssfdc->logic_block_map) 335 - goto out_err; 335 + goto out_free_ssfdc; 336 336 memset(ssfdc->logic_block_map, 0xff, sizeof(ssfdc->logic_block_map[0]) * 337 337 ssfdc->map_len); 338 338 ··· 350 350 351 351 out_err: 352 352 kfree(ssfdc->logic_block_map); 353 + out_free_ssfdc: 353 354 kfree(ssfdc); 354 355 } 355 356