server: support unix domain sockets #664

Open

koi.rip 2w ago

targeting main

Open opened by and assigned to

koi.rip 2w ago targeting main

meow meow i found some time today to do this, shouldn't require much special care maintaining

closes https://tangled.org/tranquil.farm/tranquil-pds/issues/128

This pull request has no versions submitted yet.

Comments

koi.rip 2w ago

this isn't ready to merge yet, i want to create newtypes for the socket config options like lewis suggested :3 i'll be back home on monday, so opening this to not forget!

nel.pet 2w ago

well first of all compile pleaseee :3 and format. mreow

crates/tranquil-config/src/lib.rs:464 i think it would be good to provide a good default here. in my experience most people dont actually know where sockets are supposed to go (ive seen people not even know that /run is a thing so ...). maybe we have a separate enable option instead so we can default this?

crates/tranquil-server/src/main.rs:160 somewhat feel like this should be handled in the config instead? just dont allow unix socket config stuff if not on unix? idk what peeps think

uhhh maiu

koi.rip 2w ago

oh i pushed the wrong thing lol soryyy was tirebd ,,

koi.rip 2w ago

how about putting an example path in the doc instead?? meow meow

nel.pet 2w ago

crates/tranquil-config/src/lib.rs:610 style wise id prefer cfg!(not(unix)) over !cfg!(unix)

though i still think id overall prefer the whole config option just not being compiled in on non-unix platforms. so a #[cfg(unix)] on the config option fields themselves instead/as well. might want to get @oyster.cafe and/or @jola.dev oppinions on that one too tho

how about putting an example path in the doc instead?? meow meow

thats better at least. still kinda feel like it should be defaulted. might be a me thing. @oyster.cafe @jola.dev opinions meow?

oyster.cafe 2w ago

"not compiled in on non unix platforms" @nel.pet I thought the philosophy thus far is to have this be a "universal binary" as much as possible, or else I woulda made all sorts of things like S3 compile-time opt-in also 🤷 I mean I don't mind either way but for this tiny thing it'd be nice to not force windows users to recompile (not sure if this thing even compiles at all on windows rn lol)

koi.rip 2w ago

ugh yes i mean it should compile on windows, i can check later today. i think it would be actually fine to make the options not compile on non unix (other than recompilation costs) because you can use s3 platform agnostic, sockets not so much meow meow