Summary #
The new modes/minibuffer.lua calls editor:minibuffer_cancel() and editor:minibuffer_submit(), but the editor.lua diff does not show these methods being added or retained.
The Problem #
In src/cursed/modes/minibuffer.lua (new file), commands such as minibuffer_submit and minibuffer_cancel call editor:minibuffer_submit() and editor:minibuffer_cancel(). The editor.lua diff does not include the definition of these methods. If they were removed during the refactor (e.g. the old minibuffer-specific code was stripped), the commands will error with 'attempt to call a nil value'.
Impact #
- category: correctness
- description: missing editor:minibuffer_submit() and editor:minibuffer_cancel() definitions cause runtime errors in minibuffer commands
Recommended Fix #
Confirm that Editor:minibuffer_submit() and Editor:minibuffer_cancel() are defined in editor.lua. If missing, add them (they should delegate to self.minibuffer:submit() and self.minibuffer:cancel()).
Commit range: c022da8..c022da8
Code Review: CR-2026-07-27-11