Summary #
src/cursed/editor_listeners.lua on_render_diagnostic_squiggles and on_render_spell_squiggles now just return, but their replacement path via buffer properties may be incomplete.
The Problem #
The overlay functions that previously painted LSP diagnostic underlines and spell squiggles are now no-ops. While the intent is for these to be handled by buffer-owned properties spans rendered inline in view_render via resolve_grapheme_props, the LSP diagnostic spans are added via lsp.store_diagnostics using buf:set_properties. However, if store_diagnostics does not properly set the underline_color attribute on each span, the renderer will not paint the squiggles. The code path must be verified to ensure store_diagnostics calls set_properties with the correct attrs (underline_color, etc.).
Impact #
- correctness: LSP diagnostic underlines and spell squiggles may disappear if the buffer properties path is not correctly wired.
- maintainability: Dead overlay functions confuse future readers.
Recommended Fix #
Remove the no-op overlay functions entirely or verify that lsp.store_diagnostics and the spell client's add_properties_span correctly set visual attributes so the renderer paints them. Add unit tests for property-driven rendering.
References #
b5d15868..335f21a5