at-me
interactive intro to open social at-me.zzstoatzz.io
Star 24
Fork 0
Watch

code duplication: fetchAppAvatar implemented twice #4

Closed zzstoatzz.io
Closed opened by zzstoatzz.io

problem #

the fetchAppAvatar() function is completely duplicated in two files:

  • static/app.js:9-38 (for user's app circles)
  • static/login.js:78-99 (for atmosphere orbs)

identical logic maintained in two places, violating DRY principle.

impact #

  • harder to maintain
  • bug fixes need to be applied twice
  • inconsistencies can creep in
  • increased bundle size

affected files #

  • static/app.js
  • static/login.js
Sign up or Sign in to add to the discussion.