this repo has no description
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

drop unique constraint on handles (#411)

When users change their handles, that change doesnt necessarily
propagate through the whole world consistently. The big issue this
causes for us is if a user changes their handle from X to Y, and we
arent able to validate it, we dont update our accounting of that change.
Then if a new user creates an account with handle X, we fail to
correctly initialize that user because of the uniqueness constraint.


I think I'll have to manually do these migrations, i doubt gorm will
correctly swap the indexes from unique to not-unique.

I read through all the code referencing unique conflicts and handle
setting and I believe this should work just fine.

authored by

Whyrusleeping and committed by
GitHub
227cab37 5fbf7054

+2 -2
+1 -1
bgs/bgs.go
··· 455 455 CreatedAt time.Time 456 456 UpdatedAt time.Time 457 457 DeletedAt gorm.DeletedAt `gorm:"index"` 458 - Handle sql.NullString `gorm:"uniqueIndex"` 458 + Handle sql.NullString `gorm:"index"` 459 459 Did string `gorm:"uniqueIndex"` 460 460 PDS uint 461 461 ValidHandle bool `gorm:"default:true"`
+1 -1
models/models.go
··· 37 37 type ActorInfo struct { 38 38 gorm.Model 39 39 Uid Uid `gorm:"uniqueindex"` 40 - Handle sql.NullString `gorm:"uniqueindex"` 40 + Handle sql.NullString `gorm:"index"` 41 41 DisplayName string 42 42 Did string `gorm:"uniqueindex"` 43 43 Following int64