+1 -1

atproto/crypto/interop_fixtures_test.go

reviewed

··· 29 29 if err != nil { 30 30 t.Fatal(err) 31 31 } 32 32 - defer f.Close() 32 32 + defer func() { _ = f.Close() }() 33 33 34 34 fixBytes, err := io.ReadAll(f) 35 35 if err != nil {

+1

atproto/crypto/keys_test.go

reviewed

··· 14 14 msg := []byte("test-message") 15 15 midMsg := make([]byte, 13*1024) 16 16 _, err := rand.Read(midMsg) 17 17 + assert.NoError(err) 17 18 bigMsg := make([]byte, 16*1024*1024) 18 19 _, err = rand.Read(bigMsg) 19 20 assert.NoError(err)

+1 -4

atproto/crypto/p256_lowS.go

reviewed

··· 11 11 // Checks if 'S' value from a P-256 signature is "low-S". 12 12 // un-reviewed, un-safe code from: https://github.com/golang/go/issues/54549 13 13 func sigSIsLowS_P256(s *big.Int) bool { 14 14 - if s.Cmp(curveHalfOrder_P256) == 1 { 15 15 - return false 16 16 - } 17 17 - return true 14 14 + return s.Cmp(curveHalfOrder_P256) != 1 18 15 } 19 16 20 17 // Ensures that 'S' value from a P-256 signature is "low-S" variant.

+1 -1

atproto/crypto/w3c_didkey_test.go

reviewed

··· 33 33 if err != nil { 34 34 t.Fatal(err) 35 35 } 36 36 - defer f.Close() 36 36 + defer func() { _ = f.Close() }() 37 37 38 38 fixBytes, err := io.ReadAll(f) 39 39 if err != nil {