this repo has no description
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

fix parallel e2e runs

authored by

Peter Bacon Darwin and committed by
Victor Berchet
f41276c8 fca7363c

+12 -18
+4 -8
.github/workflows/playwright.yml
··· 17 17 run: npm install -g pnpm && pnpm install 18 18 - name: Install Playwright browsers 19 19 run: pnpm run install-playwright 20 - - name: Run Playwright tests 21 - run: pnpm run e2e 22 - # - uses: actions/upload-artifact@v4 23 - # if: always() 24 - # with: 25 - # name: api-playwright-report 26 - # path: next-apps/*/playwright-report/ 27 - # retention-days: 30 20 + - name: Run playwright tests (api) 21 + run: pnpm -F api run e2e 22 + - name: Run playwright tests (create-next-app) 23 + run: pnpm -F create-next-app run e2e
+3 -3
examples/api/e2e-tests/base.spec.ts
··· 3 3 test("the application's noop index page is visible and it allows navigating to the hello-world api route", async ({ 4 4 page, 5 5 }) => { 6 - await page.goto("http://localhost:8770/"); 6 + await page.goto("/"); 7 7 await expect(page.getByText("This application doesn't have")).toBeVisible(); 8 8 await page.getByRole("link", { name: "/api/hello" }).click(); 9 9 await expect(page.getByText("Hello World!")).toBeVisible(); 10 10 }); 11 11 12 12 test("the hello-world api route works as intended", async ({ page }) => { 13 - const res = await fetch("http://localhost:8770/api/hello"); 14 - expect(res.headers.get("content-type")).toContain("text/plain"); 13 + const res = await page.request.get("/api/hello"); 14 + expect(res.headers()["content-type"]).toContain("text/plain"); 15 15 expect(await res.text()).toEqual("Hello World!"); 16 16 });
-1
examples/api/package.json
··· 10 10 "build:worker": "builder", 11 11 "dev:worker": "wrangler dev --port 8770", 12 12 "preview:worker": "pnpm build:worker && pnpm dev:worker", 13 - "pree2e": "playwright install --with-deps", 14 13 "e2e": "playwright test" 15 14 }, 16 15 "dependencies": {
+1 -1
examples/api/playwright.config.ts
··· 27 27 /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */ 28 28 use: { 29 29 /* Base URL to use in actions like `await page.goto('/')`. */ 30 - // baseURL: 'http://127.0.0.1:3000', 30 + baseURL: "http://localhost:8770", 31 31 32 32 /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */ 33 33 trace: "on-first-retry",
+1 -1
examples/create-next-app/e2e/base.spec.ts
··· 3 3 test("the index page of the application shows the Next.js logo", async ({ 4 4 page, 5 5 }) => { 6 - await page.goto("http://localhost:8770/"); 6 + await page.goto("/"); 7 7 await expect(page.getByAltText("Next.js logo")).toBeVisible(); 8 8 });
+2 -2
examples/create-next-app/e2e/playwright.config.ts
··· 27 27 /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */ 28 28 use: { 29 29 /* Base URL to use in actions like `await page.goto('/')`. */ 30 - // baseURL: 'http://127.0.0.1:3000', 30 + baseURL: "http://localhost:8771", 31 31 32 32 /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */ 33 33 trace: "on-first-retry", ··· 74 74 /* Run your local dev server before starting the tests */ 75 75 webServer: { 76 76 command: "pnpm preview:worker", 77 - url: "http://localhost:8770", 77 + url: "http://localhost:8771", 78 78 reuseExistingServer: !process.env.CI, 79 79 }, 80 80 });
+1 -2
examples/create-next-app/package.json
··· 8 8 "start": "next start", 9 9 "lint": "next lint", 10 10 "build:worker": "builder", 11 - "dev:worker": "wrangler dev --port 8770", 11 + "dev:worker": "wrangler dev --port 8771", 12 12 "preview:worker": "pnpm build:worker && pnpm dev:worker", 13 - "pree2e": "playwright install --with-deps", 14 13 "e2e": "playwright test -c e2e/playwright.config.ts" 15 14 }, 16 15 "dependencies": {