Monorepo management for opam overlays
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

wal, block, sse, zephyr: remove [mutable] from never-reassigned fields

Warning 69 (unused-field, mutable-never-assigned). Four independent
record fields were flagged as mutable but the code only mutates their
referents in place, never rebinds the record slot itself:

- ocaml-wal/lib/wal.ml: [t.file] (the Eio file resource; methods call
Eio.File.pwrite_all etc., the slot is set once at open time).
- ocaml-block/lib/block.ml: [Memory.state.data] (the backing bytes,
written via Bytes.blit_string; [Bytes.t] is already mutable).
- ocaml-sse/lib/sse.ml: [Parser.t.data_buf] (a Buffer.t, written via
Buffer.add_*; the slot never changes).
- ocaml-zephyr/lib/zephyr.ml: drop [mode : Read | Write] entirely —
set at open-time, read nowhere. The open_read / open_write
constructors already distinguish the two call shapes, so mode
tracking was redundant.

+6 -1
+3
dune
··· 1 + (env 2 + (dev 3 + (flags :standard %{dune-warnings})))
+3 -1
lib/lint.ml
··· 228 228 (* ---- Dune file scanning (for executable deps not in META) ---- *) 229 229 230 230 let parse_sexps content = 231 - match Sexp.Value.parse_string_many content with Ok sexps -> sexps | Error _ -> [] 231 + match Sexp.Value.parse_string_many content with 232 + | Ok sexps -> sexps 233 + | Error _ -> [] 232 234 233 235 let field name sexps = 234 236 List.find_map