The unpac monorepo manager self-hosting as a monorepo using unpac
Makefile.dev: work around #13817 (#13818)
authored by
Gabriel Scherer
and committed by
GitHub
04693889
5cd052d2
+12
-2
+10
-1
Makefile.dev
+10
-1
Makefile.dev
···
21
21
22
22
AST_FILES=$(addsuffix .ast,$(SOURCE_FILES))
23
23
24
+
# Note: some shells do not support command-lines that contain the full
25
+
# list of source files ("too many argument"). We ensure that
26
+
# AST_FILES is only passed inside a shell command in explicit targets
27
+
# from this Makefile, and not in targets common to other makefiles
28
+
# that would be executed unconditionally. We previously had
29
+
# a `partialclean::` target performing `clean-all-asts` and that
30
+
# resulted in annoying failures for some users, see #13817.
31
+
24
32
build-all-asts:
25
33
# Recursive invocation ensures that `git ls-files` is not executed on every
26
34
# invocation of make
···
44
52
list-all-asts:
45
53
@for f in $(AST_FILES); do echo "'$$f'"; done
46
54
47
-
partialclean::
55
+
.PHONY: clean-all-asts
56
+
clean-all-asts:
48
57
@rm -f $(AST_FILES)
+2
-1
parsing/HACKING.adoc
+2
-1
parsing/HACKING.adoc
···
53
53
54
54
4. Before committing any change, remember to remove the `.ast` files
55
55
from your index (using `git reset HEAD`), and maybe remove them
56
-
completely (unless you plan to check further changes).
56
+
completely (unless you plan to check further changes) -- you can
57
+
run `make clean-all-asts` to remove them.
57
58
58
59
----
59
60
# save pre-change ASTs