+1 -1

CONTRIBUTING.md

reviewed

··· 372 372 our ability to change it in the future. 373 373 374 374 Doing this collective maintenance work is a selfless task, and we 375 375 - typically have much fewer people willing to to do it than people 375 375 + typically have much fewer people willing to do it than people 376 376 willing to submit new language features or generally evolve the 377 377 codebase for their own specific needs. Without a collective effort to 378 378 participate, we end up with a handful of people doing the vast

+3 -3

Changes

reviewed

··· 524 524 Florian Angeletti, Nicolás Ojeda Bär, Daniel Bünzli and Jeremy Yallop) 525 525 526 526 - #13695: Add Stdlib.Char.Ascii 527 527 - (Daniel Bünzli, review by by Nicolás Ojeda Bär and Jeremy Yallop) 527 527 + (Daniel Bünzli, review by Nicolás Ojeda Bär and Jeremy Yallop) 528 528 529 529 530 530 - #13720: Add Result.{get_ok',error_to_failure} ··· 1527 1527 1528 1528 ### Manual and documentation: 1529 1529 1530 1530 - - #13370: Document that that temporary variables holding GCd pointers must 1530 1530 + - #13370: Document that temporary variables holding GCd pointers must 1531 1531 not be live across a GC. 1532 1532 (Demi Marie Obenour) 1533 1533 ··· 5354 5354 to the implementation and the coercion. 5355 5355 (Leandro Ostera, review by Gabriel Scherer and Thomas Refis) 5356 5356 5357 5357 - - #10045: Add libext variable to ocamltest and enable C# tests on on mingw 5357 5357 + - #10045: Add libext variable to ocamltest and enable C# tests on mingw 5358 5358 (David Allsopp, review by Gabriel Scherer) 5359 5359 5360 5360 * #10061, #10078, #10187: remove library `ocamlopttoplevel`, remove modules

+1 -1

Makefile.common

reviewed

··· 252 252 # Macros and rules to compile OCaml programs and libraries 253 253 254 254 # The following variable is used to accumulate a list of all the CMX 255 255 - # files that get built. Is is then used in the root Makefile to express 255 255 + # files that get built. It is then used in the root Makefile to express 256 256 # the dependency on all these files on the native compiler, so that 257 257 # they get rebuilt if the native compiler is updated 258 258

+1 -1

asmcomp/afl_instrument.ml

reviewed

··· 35 35 prev_location = cur_location >> 1; 36 36 37 37 See http://lcamtuf.coredump.cx/afl/technical_details.txt or 38 38 - docs/technical_details.txt in afl-fuzz source for for a full 38 38 + docs/technical_details.txt in afl-fuzz source for a full 39 39 description of what's going on. *) 40 40 let cur_location = Random.int afl_map_size in 41 41 let cur_pos = V.create_local "pos" in

+1 -1

asmcomp/linearize.ml

reviewed

··· 87 87 (* This dead instruction cannot be replaced by Ladjust_trap_depth, 88 88 because the units don't match: the argument of Istackoffset is in bytes, 89 89 whereas the argument of Ladjust_trap_depth is in trap frames, 90 90 - and the size of trap frames is machine-dependant and therefore not 90 90 + and the size of trap frames is machine-dependent and therefore not 91 91 available here. *) 92 92 { n with next = discard_dead_code n.next; } 93 93 | _ -> discard_dead_code n.next

+1 -1

lambda/simplif.ml

reviewed

··· 823 823 let static_id = Hashtbl.create 16 in (* function id -> static id *) 824 824 let static = LamTbl.create 16 in (* scope -> static function on that scope *) 825 825 (* We keep track of the current "tail scope", identified 826 826 - by the outermost lambda for which the the current lambda 826 826 + by the outermost lambda for which the current lambda 827 827 is in tail position. *) 828 828 let current_scope = ref lam in 829 829 (* PR11383: We will only apply the transformation if we don't have to move

+1 -1

man/ocamlmktop.1

reviewed

··· 91 91 .TP 92 92 .BI \-o " exec\-file" 93 93 Specify the name of the toplevel file produced by the linker. 94 94 - The default is is 94 94 + The default is 95 95 .BR a.out . 96 96 97 97 .SH SEE ALSO

+1 -1

manual/src/refman/extensions/attributes.etex

reviewed

··· 245 245 only triggered for single argument constructor. 246 246 \item 247 247 "ocaml.tailcall" or "tailcall" can be applied to function application 248 248 - in order to check that the call is tailcall optimized. If it it not 248 248 + in order to check that the call is tailcall optimized. If it is not 249 249 the case, a warning (51) is emitted. 250 250 \item 251 251 "ocaml.inline" or "inline" take either "never", "always" or nothing as

+1 -1

manual/src/refman/extensions/doccomments.etex

reviewed

··· 95 95 96 96 Comments which appear {\em immediately after} a labelled argument, 97 97 record field, variant constructor, object method or polymorphic variant 98 98 - constructor are are converted into @attribute@s. Immediately 98 98 + constructor are converted into @attribute@s. Immediately 99 99 after means that there must be no blank lines or other documentation 100 100 comments between them. For example: 101 101

+1 -1

manual/src/tutorials/polyvariant.etex

reviewed

··· 130 130 | #myvariant -> "myvariant" 131 131 | `Tag3 -> "Tag3";; 132 132 \end{caml_example} 133 133 - or combined with with aliases. 133 133 + or combined with aliases. 134 134 \begin{caml_example}{toplevel} 135 135 let g1 = function `Tag1 _ -> "Tag1" | `Tag2 _ -> "Tag2";; 136 136 let g = function

+1 -1

ocamldoc/odoc_exception.mli

reviewed

··· 16 16 (** Representation and manipulation of exceptions. *) 17 17 18 18 (** This module has an implementation although it declares only types. 19 19 - This is because other modules use the let module construct ot access it 19 19 + This is because other modules use the let module construct to access it 20 20 so it is needed as a real module. *) 21 21 22 22 module Name = Odoc_name

+1 -1

otherlibs/runtime_events/runtime_events.ml

reviewed

··· 369 369 lifecycle: (int -> Timestamp.t -> lifecycle 370 370 -> int option -> unit) option; 371 371 lost_events: (int -> int -> unit) option; 372 372 - (* user event callbacks is an array containing at each indice [i] a list 372 372 + (* user event callbacks is an array containing at each index [i] a list 373 373 of functions to call when an event of type id [i] happen *) 374 374 user_events: any_callback list array; 375 375 }

+1 -1

runtime/caml/config.h

reviewed

··· 160 160 161 161 /* The size of a page for memory management (in bytes) is [1 << Page_log]. 162 162 [Page_size] must be a multiple of [sizeof (value)]. 163 163 - [Page_log] must be be >= 8 and <= 20. 163 163 + [Page_log] must be >= 8 and <= 20. 164 164 Do not change the definition of [Page_size]. */ 165 165 #define Page_log 12 /* A page is 4 kilobytes. */ 166 166 #define Page_size (1 << Page_log)

+1 -1

runtime/major_gc.c

reviewed

··· 1146 1146 uintnat local_heap_bsize = caml_heap_size(Caml_state->shared_heap); 1147 1147 1148 1148 /* When the mark stack might not increase, we count the large mark entries 1149 1149 - to adjust our alloaction. This is needed because large mark stack entries 1149 1149 + to adjust our allocation. This is needed because large mark stack entries 1150 1150 will not compress and because we are using a domain local heap bound we 1151 1151 need to fit large blocks into the local mark stack. See PR#11284 */ 1152 1152 if (mark_stack_bsize >= local_heap_bsize / 32) {

+1 -1

stdlib/arg.ml

reviewed

··· 252 252 f (List.rev !acc) 253 253 | Expand f -> 254 254 if not allow_expand then 255 255 - raise (Invalid_argument "Arg.Expand is is only allowed with \ 255 255 + raise (Invalid_argument "Arg.Expand is only allowed with \ 256 256 Arg.parse_and_expand_argv_dynamic"); 257 257 let arg = get_arg () in 258 258 let newarg = f arg in

+1 -1

testsuite/tests/hidden_includes/test.ml

reviewed

··· 10 10 - Compiling libc with -H liba allows the compiler to see the type definitions 11 11 in liba, but doesn't allow c.ml to reference it directly. 12 12 13 13 - - If -H and -I are are passed for two different versions of liba, the -I one 13 13 + - If -H and -I are passed for two different versions of liba, the -I one 14 14 takes priority. 15 15 16 16 - If -H is passed twice with two different versions of liba, the first takes

+1 -1

testsuite/tests/typing-modules/mixmod5.ml

reviewed

··· 6 6 7 7 (* The types involved in our recursion *) 8 8 module type ET = sig type exp end 9 9 - (* The recursive operations on our our types *) 9 9 + (* The recursive operations on our types *) 10 10 module type E = 11 11 sig 12 12 include ET

+1 -1

testsuite/tools/environment.ml

reviewed

··· 395 395 let lines = 396 396 let ic = Unix.in_channel_of_descr stdout in 397 397 (* Some of the tests send lines of text which end with '\r'. On native 398 398 - Windows, this will _correctly_ cause "\r\r\n" to be be sent down 398 398 + Windows, this will _correctly_ cause "\r\r\n" to be sent down 399 399 the pipe and text mode will _correctly_ translate that to "\r\n" 400 400 (and the caller receives a line ending with '\r'). 401 401 On Cygwin, where the process sending the text is a Unix process,

+1 -1

typing/ctype.ml

reviewed

··· 231 231 if ty.level = generic_level then () else 232 232 match ty.desc with 233 233 | Tvar _ when structure -> 234 234 - (* In structure mode, we do do not generalize type variables, 234 234 + (* In structure mode, we do not generalize type variables, 235 235 so we need to lower their level, and move them to an outer pool. 236 236 The goal of this mode is to allow unsharing inner nodes 237 237 without introducing polymorphism.

+1 -1

typing/out_type.ml

reviewed

··· 248 248 type r = Avoid__me.t 249 249 end 250 250 }] 251 251 - It is is important that in the definition of [t] that the outer type [t] is 251 251 + It is important that in the definition of [t] that the outer type [t] is 252 252 printed as [t/2] reserving the name [t] to the type being defined in the 253 253 current recursive definition. 254 254 Contrarily, in the definition of [r], one should not shorten the

+1 -1

typing/typecore.ml

reviewed

··· 813 813 (* Create two instances with identical variables but independent structure. 814 814 NB: [generic_instance] can only be used if the variables of the 815 815 original type are not at [generic_level], but in the [cty_type] of 816 816 - [build_as_type_extra], they are at at [generic_level]. 816 816 + [build_as_type_extra], they are at [generic_level]. 817 817 If we used [generic_instance] we would lose the sharing between variables 818 818 in the returned types. *) 819 819 let instance_unshared ty =