+5 -5

Changes

reviewed

··· 317 317 (Keryan Didier, review by Vincent Laviron and Gabriel Scherer) 318 318 319 319 - #14155: Audit unexecuted phrases in compiler expect tests and 320 320 - fix all occurences 320 320 + fix all occurrences 321 321 (Stefan Muenzel, review by Gabriel Scherer) 322 322 323 323 - #14163, #14176: add a filename location to the deprecation alert for implicit ··· 684 684 - #13921: Set cloexec correctly on CRT file descriptors created by the Unix 685 685 library on Windows. The inheritance on the underlying Win32 handles was 686 686 correctly set, but the book-keeping for the CRT was leaking the value of 687 687 - non-inherited handles which combined with re-use of HANDLE values within 687 687 + non-inherited handles which combined with reuse of HANDLE values within 688 688 processes could appear to make a CRT file descriptor "re-open". 689 689 (David Allsopp, review by Nicolás Ojeda Bär) 690 690 ··· 809 809 (Samuel Vivien, review by Florian Angeletti and Gabriel Scherer) 810 810 811 811 - #13814, 13898: Add an `unused-type-declaration` warning when using 812 812 - a `t as 'a` with no other occurences of `'a` 812 812 + a `t as 'a` with no other occurrences of `'a` 813 813 (Samuel Vivien, review by Florian Angeletti, Kate Deplaix) 814 814 815 815 - #13818: better delimited hints in error message ··· 888 888 content of a `Tpackage` node 889 889 (Samuel Vivien, review by Florian Angeletti) 890 890 891 891 - - #13866: Modified occurence check that prevents recursive types for it to see 891 891 + - #13866: Modified occurrence check that prevents recursive types for it to see 892 892 the checked type as a graph rather than a tree 893 893 (Samuel Vivien, report by Didier Remy, review by Florian Angeletti 894 894 and Jacques Garrigue) ··· 1198 1198 (Antonin Décimo, review by David Allsopp) 1199 1199 1200 1200 - #10696: Introduce __has_attribute and __has_c_attributes in 1201 1201 - <caml/misc.h> to test the support of specific atributes in C 1201 1201 + <caml/misc.h> to test the support of specific attributes in C 1202 1202 code. Introduce fallthrough as a wrapper around the fallthrough 1203 1203 attribute. 1204 1204 (Antonin Décimo, review by Nicolás Ojeda Bär, Xavier Leroy, and

+1 -1

HACKING.adoc

reviewed

··· 682 682 - `run-crosscompiler-tests`: build various cross-compilers and test them; 683 683 - `run-thread-sanitizer`: build the distribution with the Thread 684 684 Sanitizer (TSAN), and run the whole testsuite instrumented with TSAN; 685 685 - - `run-multicoretests`: run an extensive testsuite convering multicore 685 685 + - `run-multicoretests`: run an extensive testsuite covering multicore 686 686 features. 687 687 688 688 ==== INRIA's Continuous Integration (CI)

+1 -1

INSTALL.adoc

reviewed

··· 245 245 246 246 If you have built a Unix-to-Windows cross compiler, you must first make sure 247 247 that `ocamlopt` can find the `flexlink` executable in `$PATH` when it needs to 248 248 - link. Boostrapping `flexdll` builds a `flexlink.exe` (note the `.exe`!), so you 248 248 + link. Bootstrapping `flexdll` builds a `flexlink.exe` (note the `.exe`!), so you 249 249 can: 250 250 251 251 ....

+1 -1

Makefile.cross

reviewed

··· 14 14 15 15 # Recipes to build a cross compiler (_not_ cross-compiling the compiler), aka 16 16 # generating code that will run on `target`, assuming that a non-cross OCaml 17 17 - # compiler (so targetting our build machine) of the same version is available in 17 17 + # compiler (so targeting our build machine) of the same version is available in 18 18 # $PATH 19 19 20 20 # As the cross compiler will be linked with the _build_ version of

+1 -1

asmcomp/cmm_helpers.ml

reviewed

··· 1443 1443 1444 1444 type switch_arg = Tagged of expression | Untagged of expression 1445 1445 1446 1446 - (** This function takes a switch on immedate values, 1446 1446 + (** This function takes a switch on immediate values, 1447 1447 for example: 1448 1448 int 0: 1 1449 1449 int 1: 3

+1 -1

lambda/matching.ml

reviewed

··· 2759 2759 i_max := i; 2760 2760 c_max := c 2761 2761 ) else if c = !c_max then ( 2762 2762 - (* Pick the miminal [i] which has maximal [c], and not just 2762 2762 + (* Pick the minimal [i] which has maximal [c], and not just 2763 2763 the first [i], as the Hashtbl iteration order is not 2764 2764 deterministic: see #14088. *) 2765 2765 i_max := min i !i_max;

+1 -1

man/ocamlc.1

reviewed

··· 407 407 .TP 408 408 .BI \-cmi-file " filename" 409 409 Type-check the source implementation to be compiled against the 410 410 - specified interface file (by-passes the normal lookup for .mli and .cmi files). 410 410 + specified interface file (bypasses the normal lookup for .mli and .cmi files). 411 411 .TP 412 412 .BI \-I " directory" 413 413 Add the given directory to the list of directories searched for

+1 -1

man/ocamlopt.1

reviewed

··· 309 309 .TP 310 310 .BI \-cmi\-file " filename" 311 311 Type-check the source implementation to be compiled against the 312 312 - specified interface file (by-passes the normal lookup for .mli and .cmi files). 312 312 + specified interface file (bypasses the normal lookup for .mli and .cmi files). 313 313 .TP 314 314 .BI \-I " directory" 315 315 Add the given directory to the list of directories searched for

+1 -1

manual/src/cmds/runtime-tracing.etex

reviewed

··· 92 92 The ring buffer implementation used in runtime events can be written by at most 93 93 one producer at a time but can be read simultaneously by multiple consumers 94 94 without coordination from the producer. There is a unique ring buffer for every 95 95 - running domain and, on domain termination, ring buffers may be re-used for newly 95 95 + running domain and, on domain termination, ring buffers may be reused for newly 96 96 spawned domains. Ring buffers are only allocated (including for the main 97 97 domain) when runtime events are enabled. The ring buffers themselves are stored 98 98 in a memory-mapped file with the processes identifier as the name and the

+1 -1

otherlibs/runtime_events/runtime_events.mli

reviewed

··· 47 47 *) 48 48 49 49 (** The type for counter events emitted by the runtime. Counter events are used 50 50 - to measure a quantity at a point in time or record the occurence of an event. 50 50 + to measure a quantity at a point in time or record the occurrence of an event. 51 51 In the latter case their value will be one. *) 52 52 type runtime_counter = 53 53 | EV_C_FORCE_MINOR_ALLOC_SMALL

+1 -1

parsing/location.mli

reviewed

··· 254 254 Format.formatter -> Format_doc.t -> unit; 255 255 } 256 256 (** A printer for [report]s, defined using open-recursion. 257 257 - The goal is to make it easy to define new printers by re-using code from 257 257 + The goal is to make it easy to define new printers by reusing code from 258 258 existing ones. 259 259 *) 260 260

+2 -2

parsing/parser.mly

reviewed

··· 3706 3706 { Ptyp_arrow(label, domain, codomain) } 3707 3707 ) 3708 3708 { $1 } 3709 3709 - (* The next two cases are for labled tuples - see comment on [tuple_type] 3709 3709 + (* The next two cases are for labeled tuples - see comment on [tuple_type] 3710 3710 below. 3711 3711 3712 3712 The first case is present just to resolve a shift/reduce conflict in a ··· 3759 3759 label is not parsed as a proper_tuple_type, but rather as a case of 3760 3760 function_type above. This resolves ambiguities around [x:t1 * t2 -> t3] 3761 3761 which must continue to parse as a function with one labeled argument even in 3762 3762 - the presence of labled tuples. 3762 3762 + the presence of labeled tuples. 3763 3763 *) 3764 3764 tuple_type: 3765 3765 | ty = atomic_type

+1 -1

parsing/unit_info.mli

reviewed

··· 152 152 (** {1:ml_mli_cmi_interaction Mli and cmi derived from implementation files } *) 153 153 154 154 (** The compilation of module implementation changes in presence of mli and cmi 155 155 - files, the function belows help to handle this. *) 155 155 + files, the function below help to handle this. *) 156 156 157 157 (** [mli_from_source u] is the interface source filename associated to the unit 158 158 [u]. The actual suffix depends on {!Config.interface_suffix}.

+1 -1

release-info/News

reviewed

··· 9 9 - Thread sanitizer support 10 10 - New Dynarray module 11 11 - New -H flag for hidden include directories 12 12 - - Project-wide occurence metadata support for developer tools 12 12 + - Project-wide occurrence metadata support for developer tools 13 13 - Raw identifiers 14 14 - Local open in type expressions 15 15

+1 -1

release-info/howto.md

reviewed

··· 410 410 See https://github.com/compiler-explorer/compiler-explorer/pull/6735 411 411 and https://github.com/compiler-explorer/infra/pull/1359 as examples. 412 412 413 413 - This should be expanded, once we have more experince with the process 413 413 + This should be expanded, once we have more experience with the process 414 414 415 415 # Appendix 416 416

+1 -1

runtime/caml/mlvalues.h

reviewed

··· 502 502 Caml_out_of_heap_header_with_reserved(wosize, tag, 0) 503 503 504 504 505 505 - /* Obsolete -- suppport for unsafe encoded exceptions. 505 505 + /* Obsolete -- support for unsafe encoded exceptions. 506 506 507 507 Before caml_result was available, we used an unsafe encoding of it 508 508 into the 'value' type, where encoded exceptions have their second

+1 -1

runtime/domain.c

reviewed

··· 2249 2249 2250 2250 if (!last) caml_assert_shared_heap_is_empty(domain_state->shared_heap); 2251 2251 2252 2252 - /* [domain_state] may be re-used by a fresh domain here, now that we 2252 2252 + /* [domain_state] may be reused by a fresh domain here, now that we 2253 2253 have done [stop_active_domain] and released the 2254 2254 [all_domains_lock]. In particular, we cannot touch 2255 2255 [domain_self->interruptor] after here because it may be reused.

+1 -1

runtime/memprof.c

reviewed

··· 1202 1202 * * lambda]. We could use a more involved algorithm, but this should 1203 1203 * be good enough since, in the typical use case, [lambda] << 0.01 and 1204 1204 * therefore the generation of the binomial variable is amortized by 1205 1205 - * the initialialization of the corresponding block. 1205 1205 + * the initialization of the corresponding block. 1206 1206 * 1207 1207 * If needed, we could use algorithm BTRS from the paper: 1208 1208 * Hormann, Wolfgang. "The generation of binomial random variates."

+1 -1

stdlib/format.mli

reviewed

··· 931 931 932 932 val utf_8_scalar_width: string -> pos:int -> len:int -> int 933 933 (** [utf_8_scalar_width s ~pos ~len] is the number of unicode scalar values in 934 934 - the substring [String.sub s pos len]. Invalid byte sequences are implictly 934 934 + the substring [String.sub s pos len]. Invalid byte sequences are implicitly 935 935 replaced by [U+FFFD] since this yields a better width approximation for 936 936 other ascii-based encoding scheme like ISO-8859-15. This is the default 937 937 [out_width] function since OCaml 5.4.

+1 -1

stdlib/fun.mli

reviewed

··· 148 148 149 149 {3:hflip {{!val:flip}flip}} 150 150 151 151 - Useing [flip] to reverse the comparator passed to {!val:List.sort}, which sorts 151 151 + Using [flip] to reverse the comparator passed to {!val:List.sort}, which sorts 152 152 in the opposite order 153 153 {[ 154 154 # List.sort (Fun.flip Int.compare) [5; 3; 9; 0; 1; 6; 8];;

+1 -1

stdlib/string.mli

reviewed

··· 413 413 {{:https://unicode.org/glossary/#normalization_form_c}NFC} gives 414 414 better results. 415 415 416 416 - {b Note.} This implements the simpler Optimal String Alignement (OSA) 416 416 + {b Note.} This implements the simpler Optimal String Alignment (OSA) 417 417 distance, not the Damerau-Levenshtein distance. With this function 418 418 ["ca"] and ["abc"] have a distance of 3 not 2. 419 419

+1 -1

stdlib/stringLabels.mli

reviewed

··· 413 413 {{:https://unicode.org/glossary/#normalization_form_c}NFC} gives 414 414 better results. 415 415 416 416 - {b Note.} This implements the simpler Optimal String Alignement (OSA) 416 416 + {b Note.} This implements the simpler Optimal String Alignment (OSA) 417 417 distance, not the Damerau-Levenshtein distance. With this function 418 418 ["ca"] and ["abc"] have a distance of 3 not 2. 419 419

+1 -1

testsuite/in_prefix/README.md

reviewed

··· 48 48 - Environment variables `CAML_LD_LIBRARY_PATH` and `OCAMLLIB` are manipulated to 49 49 allow the compiler to operate 50 50 - Bytecode executables which will no longer be able to find `ocamlrun` are 51 51 - explictly passed to `ocamlrun`. The harness always verifies that this step is 51 51 + explicitly passed to `ocamlrun`. The harness always verifies that this step is 52 52 required by first executing the binary and ensuring that it fails and then 53 53 passing it directly to `ocamlrun`. 54 54

+1 -1

testsuite/tests/lib-array/test_array.ml

reviewed

··· 229 229 array length differences. *) 230 230 test [|0;1;2;2;2|] [|0;1|] ~cmp:1; 231 231 test [|0;1|] [|0;1;2;2;2|] ~cmp:~-1; 232 232 - (* If the length is different it is sufficent to order arrays and 232 232 + (* If the length is different it is sufficient to order arrays and 233 233 we do not compare elements. This tests that so that 234 234 a possible behaviour change in the future can be detected *) 235 235 assert (Array.compare (fun _ _ -> assert false) [|0;1|] [|0;1;2|] = -1);

+2 -2

testsuite/tests/parsing/comments.ml

reviewed

··· 21 21 3;; 22 22 23 23 24 24 - let four = (* We are inserting quoted litteral here {p|*)|p}, {œ|(*|œ} *) 4;; 24 24 + let four = (* We are inserting quoted literal here {p|*)|p}, {œ|(*|œ} *) 4;; 25 25 26 26 let set = (** [x < min({x'|x'∊l})] *) 5;; 27 27 ··· 46 46 3;; 47 47 48 48 49 49 - let four = (* We are inserting quoted litteral here {p|*)|p}, {œ|(*|œ} *) 4;; 49 49 + let four = (* We are inserting quoted literal here {p|*)|p}, {œ|(*|œ} *) 4;; 50 50 51 51 let set = (** [x < min({x'|x'∊l})] *) 5;; 52 52

+2 -2

testsuite/tests/shape-index/index_aliases.ml

reviewed

··· 41 41 module Y = X.M 42 42 module Z = Y 43 43 44 44 - (* FIXME: this sould be (Approx (No_uid)), not (Internal_error_no_uid) *) 44 44 + (* FIXME: this should be (Approx (No_uid)), not (Internal_error_no_uid) *) 45 45 let _ = Z.s 46 46 47 47 module Arg = struct end 48 48 module FArg = X.F (Arg) 49 49 open FArg 50 50 51 51 - (* FIXME: this sould be (Approx (No_uid)), not (Internal_error_no_uid) *) 51 51 + (* FIXME: this should be (Approx (No_uid)), not (Internal_error_no_uid) *) 52 52 type u = t

+1 -1

testsuite/tests/tool-toplevel/install_printer.ml

reviewed

··· 45 45 46 46 #install_printer print_generic;; 47 47 [D (0, A); D (42, B)];; 48 48 - (* Simple printer witn non_generic variable *) 48 48 + (* Simple printer with non_generic variable *) 49 49 50 50 let pp_option_ref = Fun.id @@ fun ppf x -> 51 51 match !x with

+1 -1

testsuite/tests/typing-external/non_syntactic_arity.ml

reviewed

··· 8 8 1 | external fail: (int -> int as 'a) -> 'a = "%identity" 9 9 ^^ 10 10 Error: This external declaration has a non-syntactic arity, 11 11 - its arity is greater than its syntatic arity. 11 11 + its arity is greater than its syntactic arity. 12 12 |}]

+2 -2

testsuite/tests/typing-modules/functors.ml

reviewed

··· 1761 1761 end) = 1762 1762 struct end 1763 1763 1764 1764 - (** The definition of `F` and its application belows disagree on 1764 1764 + (** The definition of `F` and its application below disagree on 1765 1765 the arity of `t`, we should not equate the two types *) 1766 1766 1767 1767 include ··· 1895 1895 |}] 1896 1896 1897 1897 1898 1898 - (** The definition of `H` and its application belows still disagree on 1898 1898 + (** The definition of `H` and its application below still disagree on 1899 1899 the arity of `t`. However, they agree on the type constructor s. 1900 1900 Currently, we don't add an equality X.s = G($1).s, but we may want 1901 1901 to do so in the future. *)

+1 -1

testsuite/tests/typing-modules/merge_constraint.ml

reviewed

··· 427 427 428 428 The first set of example use paths with functor applications to tests deep 429 429 substitutions and handling of prefixes. The tests for functor parameters and 430 430 - recursive modules are bellow. 430 430 + recursive modules are below. 431 431 *) 432 432 433 433 (* Introduction of an invalid alias via a destructive module constraint should

+1 -1

testsuite/tests/uids/intf_uids_test.ml

reviewed

··· 17 17 *) 18 18 19 19 (* This test illustrates the fact that uids are tagged to indicate if they 20 20 - originate from an interface of an implementation: it prints the delcarations 20 20 + originate from an interface of an implementation: it prints the declarations 21 21 written in the cmt file for the interface and then for the implementation. 22 22 These should not overlap. *)

+1 -1

testsuite/tools/harness.mli

reviewed

··· 115 115 the following transformations: 116 116 117 117 - ["$bindir"] or ["$libdir"] if [path] is exactly [~bindir_suffix] or 118 118 - [~libdir_suffix] (this captures passing those two variabes to the test 118 118 + [~libdir_suffix] (this captures passing those two variables to the test 119 119 programs) 120 120 - if [path] begins with [~prefix] then the text is replaced with 121 121 ["$prefix"] (which can create ["$prefix.new/"], etc.). Additionally, if

+1 -1

testsuite/tools/toolchain.ml

reviewed

··· 48 48 49 49 let assembler_embeds_build_path = 50 50 if is_clang_assembler && Config.system = "macosx" then 51 51 - (* Xcode 16 targetting macOS 15 or later uses DWARF v5 and embeds build 51 51 + (* Xcode 16 targeting macOS 15 or later uses DWARF v5 and embeds build 52 52 paths by default, cf. https://developer.apple.com/documentation/xcode-release-notes/xcode-16-release-notes *) 53 53 match String.split_on_char '-' Config.c_compiler_vendor, 54 54 String.split_on_char '-' Config.target with

+2 -2

typing/ctype.ml

reviewed

··· 2333 2333 2334 2334 (* Two labels are considered compatible under certain conditions. 2335 2335 - they are the same 2336 2336 - - in classic mode, only optional labels are relavant 2336 2336 + - in classic mode, only optional labels are relevant 2337 2337 - in pattern mode, we act as if we were in classic mode. If not, interactions 2338 2338 with GADTs from files compiled in classic mode would be unsound. 2339 2339 *) ··· 2366 2366 witness could exist or not. Typically, this is the case for 2367 2367 abstract types, which could be equal to anything, depending on 2368 2368 their actual definition. As a result [mcomp] overapproximates 2369 2369 - compatibilty, i.e. when it says that two types are incompatible, we 2369 2369 + compatibility, i.e. when it says that two types are incompatible, we 2370 2370 are sure that there exists no equality witness, but if it does not 2371 2371 say so, there is no guarantee that such a witness could exist. 2372 2372 *)

+1 -1

typing/gprinttyp.ml

reviewed

··· 199 199 Hashtbl.replace id_map.tbl id last; 200 200 Main last 201 201 202 202 - (** Generate color from the node id to keep the color stable inbetween 202 202 + (** Generate color from the node id to keep the color stable in between 203 203 different calls to the typechecker on the same input. *) 204 204 let colorize_id params id = 205 205 if not params.colorize then None

+2 -2

typing/includemod.ml

reviewed

··· 153 153 | Strictly_positive 154 154 (** Strictly positive positions are notable for tools since they are the 155 155 the case where we match a implementation definition with an interface 156 156 - declaration. Oherwise in the positive case we are matching 157 157 - declatations inside functor arguments at even level of nesting.*) 156 156 + declaration. Otherwise in the positive case we are matching 157 157 + declarations inside functor arguments at even level of nesting.*) 158 158 | Positive 159 159 | Negative 160 160

+1 -1

typing/out_type.mli

reviewed

··· 41 41 42 42 val wrap_printing_env: error:bool -> Env.t -> (unit -> 'a) -> 'a 43 43 (** Call the function using the environment for type path shortening 44 44 - This affects all the printing and tree cration functions functions below 44 44 + This affects all the printing and tree creation functions below 45 45 Also, if [~error:true], then disable the loading of cmis *) 46 46 47 47

+1 -1

typing/rawprinttyp.mli

reviewed

··· 14 14 (**************************************************************************) 15 15 16 16 (** This module provides function(s) for printing the internal representation of 17 17 - type expressions. It is targetted at internal use when debbuging the 17 17 + type expressions. It is targeted at internal use when debugging the 18 18 compiler itself. *) 19 19 20 20 val type_expr: Format.formatter -> Types.type_expr -> unit

+1 -1

typing/subst.mli

reviewed

··· 35 35 safe and unsafe variant. Only unsafe substitutions may expand a module type 36 36 path into a generic module type. *) 37 37 38 38 - (** Type familly for substitutions *) 38 38 + (** Type family for substitutions *) 39 39 type +'k subst 40 40 41 41 type safe = [`Safe]

+1 -1

typing/typedecl.ml

reviewed

··· 2361 2361 | External_with_non_syntactic_arity -> 2362 2362 Location.errorf ~loc 2363 2363 "This external declaration has a non-syntactic arity,@ \ 2364 2364 - its arity is greater than its syntatic arity." 2364 2364 + its arity is greater than its syntactic arity." 2365 2365 2366 2366 2367 2367 let () =

+1 -1

utils/config.mli

reviewed

··· 199 199 (** Name of operating system for the native-code compiler *) 200 200 201 201 val target_os_type: string 202 202 - (** Operating system targetted by the native-code compiler. One of 202 202 + (** Operating system targeted by the native-code compiler. One of 203 203 - ["Unix"] (for all Unix versions, including Linux and macOS), 204 204 - ["Win32"] (for MS-Windows, OCaml compiled with MSVC++ or MinGW-w64), 205 205 - ["Cygwin"] (for MS-Windows, OCaml compiled with Cygwin). *)

+1 -1

utils/diffing.ml

reviewed

··· 357 357 the element order [[P_0;...; P_n]]. 358 358 359 359 This is why we choose to start with the [Del] case since path ending with 360 360 - [Del+] suffix are likely to correspond to parital application in the 360 360 + [Del+] suffix are likely to correspond to partial application in the 361 361 functor application case. 362 362 Similarly, large block of deletions or insertions at the end of the 363 363 definitions might point toward incomplete definitions.

+1 -1

utils/format_doc.mli

reviewed

··· 172 172 val compat1: ('p1 -> 'a printer) -> ('p1 -> 'a format_printer) 173 173 val compat2: ('p1 -> 'p2 -> 'a printer) -> ('p1 -> 'p2 -> 'a format_printer) 174 174 175 175 - (** If necessary, embbed a {!Format} printer inside a formatting instruction 175 175 + (** If necessary, embed a {!Format} printer inside a formatting instruction 176 176 stream. This breaks every guarantees provided by {!Format_doc}. *) 177 177 val deprecated_printer: (Format.formatter -> unit) -> formatter -> unit 178 178 val deprecated: 'a format_printer -> 'a printer

+1 -1

utils/misc.ml

reviewed

··· 964 964 let la, lb = String.length a, String.length b in 965 965 let cutoff = 966 966 (* using max_int for cutoff would cause overflows in (i + cutoff + 1); 967 967 - we bring it back to the (max la lb) worstcase *) 967 967 + we bring it back to the (max la lb) worst case *) 968 968 Int.min (Int.max la lb) cutoff in 969 969 if abs (la - lb) > cutoff then None 970 970 else begin