this repo has no description
resolve some TODOs
+1
-8
+1
-4
atproto/auth/permission.go
+1
-4
atproto/auth/permission.go
···
69
69
if p.NSID != "" {
70
70
positional = p.NSID
71
71
}
72
-
// TODO: other params...
73
72
if p.Audience != "" {
74
73
params.Set("aud", p.Audience)
75
74
}
···
158
157
}
159
158
160
159
func ParseScope(scope string) (*Permission, error) {
161
-
// TODO: should unknown params be an error?
162
-
163
160
g, err := ParseGenericScope(scope)
164
161
if err != nil {
165
162
return nil, err
···
268
265
if p.Audience != "" && p.Audience != "*" && !validServiceRef(p.Audience) {
269
266
return nil, ErrInvalidPermissionSyntax
270
267
}
271
-
// TODO: possibly other params in the future...
268
+
// possibly other params in the future...
272
269
case "repo":
273
270
for k, _ := range g.Params {
274
271
if !(k == "collection" || k == "action") {
-4
atproto/auth/testdata/permission_scopes_invalid.txt
-4
atproto/auth/testdata/permission_scopes_invalid.txt
···
95
95
Rpc?lxm=com.example.method1&aud=*
96
96
rpc:com.example.service?aud=did:web:example.com%23service_id&invalid=param
97
97
98
-
# TODO: DID-level parsing
99
-
#rpc:foo.bar.baz?aud=did:plc:111%23service_id
100
-
#rpc:foo.bar.baz?aud=did:foo:bar%23service_id
101
-
102
98
# missing LXM
103
99
rpc?aud=did:web:example.com%23service_id
104
100
rpc:?aud=did:web:example.com%23service_id