+18 -2

app/lib/atproto/client.ts

reviewed

··· 508 508 } 509 509 510 510 /** 511 511 + * User-Agent sent on every AppView request so Bluesky ops can identify our 512 512 + * traffic and contact us if we're misbehaving. 513 513 + */ 514 514 + export const ATPROTO_USER_AGENT = 'favs.blue (+https://favs.blue)' 515 515 + 516 516 + /** 511 517 * Create a production AtprotoClient pointed at public.api.bsky.app. 512 518 * 513 519 * Per spec §6: "All three methods MUST go through public.api.bsky.app (not 514 520 * bsky.social) — that's the public unauthenticated endpoint with the more 515 521 * generous rate limits." 522 522 + * 523 523 + * The optional `fetchImpl` override is used by tests to observe the outbound 524 524 + * request (e.g. to assert the User-Agent header is set). 516 525 */ 517 517 - export function createAtprotoClient(onRequest?: AtprotoRequestHook): AtprotoClient { 518 518 - const agent = new Agent({ service: 'https://public.api.bsky.app' } as never) 526 526 + export function createAtprotoClient( 527 527 + onRequest?: AtprotoRequestHook, 528 528 + fetchImpl?: typeof globalThis.fetch 529 529 + ): AtprotoClient { 530 530 + const agent = new Agent({ 531 531 + service: 'https://public.api.bsky.app', 532 532 + headers: { 'User-Agent': ATPROTO_USER_AGENT }, 533 533 + ...(fetchImpl ? { fetch: fetchImpl } : {}), 534 534 + } as never) 519 535 return new AtprotoClient(agent as unknown as AgentLike, defaultSleep, onRequest) 520 536 }

+20

tests/unit/atproto/client.spec.ts

reviewed

··· 1 1 import { test } from '@japa/runner' 2 2 import { AtprotoClient, BlueskyRateLimitedError } from '#lib/atproto/index' 3 3 + import { ATPROTO_USER_AGENT, createAtprotoClient } from '#lib/atproto/client' 3 4 4 5 // --------------------------------------------------------------------------- 5 6 // Mock Agent factory ··· 462 463 assert.strictEqual(rlErr.cause, rateLimitError) 463 464 }).timeout(10000) 464 465 }) 466 466 + 467 467 + test.group('createAtprotoClient — User-Agent', () => { 468 468 + test('sends a favs.blue User-Agent header on AppView requests', async ({ assert }) => { 469 469 + let capturedUserAgent: string | null = null 470 470 + const fakeFetch: typeof globalThis.fetch = async (_input, init) => { 471 471 + const headers = new Headers(init?.headers) 472 472 + capturedUserAgent = headers.get('user-agent') 473 473 + return new Response(JSON.stringify({ did: 'did:plc:test' }), { 474 474 + status: 200, 475 475 + headers: { 'content-type': 'application/json' }, 476 476 + }) 477 477 + } 478 478 + 479 479 + const client = createAtprotoClient(undefined, fakeFetch) 480 480 + await client.resolveHandle('alice.bsky.social') 481 481 + 482 482 + assert.equal(capturedUserAgent, ATPROTO_USER_AGENT) 483 483 + }) 484 484 + })