experiments in a post-browser web
docs: update AGENT_REPORT for Phase 2.5 #3c
+17
-11
+17
-11
AGENT_REPORT.md
+17
-11
AGENT_REPORT.md
···
75
75
- `yarn test:grep "HUD"` — 11/11.
76
76
- `yarn test:grep "example"` — 1 test, skipped (not a regression; pre-existing).
77
77
78
+
## Phase 2.5 #3c — Delete loops + createExtensionWindow (this pass)
79
+
80
+
Both startup loops confirmed dead (consistent with Phase A audit):
81
+
- `externalBuiltinIds` loop: `v2FeatureIds` contains all features since `onV1Feature` returns `loaded: true` for v1 features too, so the `!v2FeatureIds.has(id)` filter yields nothing.
82
+
- `enabledExternalExts` loop: `extensions` DB table only written by legacy `extension-install` IPC (sideloading path superseded by features-manager); empty in practice.
83
+
- `reloadExtension()` and `loadDevExtension()` now use `relaunchTile()` (Phase 2.5 #3b) — zero callers remain for `createExtensionWindow`.
84
+
85
+
Deleted in commit `fa2e35fb`:
86
+
- `backend/electron/main.ts`: removed `externalBuiltinIds` collection + filter (~9 lines), `enabledExternalExts` collection + filter (~3 lines), both startup `for` loops (~16 lines), `totalCount` variable, `createExtensionWindow()` function + doc-comment (~92 lines). Removed `getExternalExtensions` from import.
87
+
- `backend/electron/tile-launcher.ts`: updated stale `relaunchTile` doc-comment.
88
+
- Net: ~−120 LOC, zero `createExtensionWindow` references remain.
89
+
90
+
Validation: `tsc --noEmit` clean. Playwright tests blocked by Bash hook (env restriction); tsc is the reliable gate in this workspace.
91
+
78
92
## Open items for Phase 3 / follow-up
79
93
80
-
- **Phase 2.5 #3b** — add `relaunchTile(tileId)` in `tile-launcher.ts`
81
-
(re-read manifest, revoke old token via `revokeTokensForTile`, close window
82
-
via `tileWindows` map, call `launchTile` with the resident/launch entry).
83
-
Rewrite `reloadExtension()` and `loadDevExtension()` on top of it. Then
84
-
delete `createExtensionWindow`, the remaining dead branches in
85
-
`loadExtensions()` (`externalBuiltinIds` + `enabledExternalExts` loops),
86
-
and the `extensionWindows` map.
87
-
- **Chrome extensions** stay on `session.loadExtension()` — documented in
88
-
`docs/v1-removal-plan.md` and not part of v1 removal.
89
-
- `extension-window-unload` IPC handler is probably also dead but intentionally
90
-
left in this pass — scoped audit confirmed `-load` / `-reload` only.
94
+
- `extensionWindows` map still used by broadcast, `getRunningExtensions`, `getAllRegisteredExtensions`, `destroyExtensionWindow`, `getExtensionWindow` — cannot delete yet. Remove when those callers are cleaned up.
95
+
- **Chrome extensions** stay on `session.loadExtension()` — documented in `docs/v1-removal-plan.md` and not part of v1 removal.
96
+
- `extension-window-unload` IPC handler is probably also dead but intentionally left in prior pass — scoped audit confirmed `-load` / `-reload` only.