experiments in a post-browser web
10
fork

Configure Feed

Select the types of activity you want to include in your feed.

docs(v1-removal-plan) update Phase 2.5 #3 with audit findings — only relaunchTile helper missing

+1 -1
+1 -1
docs/v1-removal-plan.md
··· 99 99 100 100 1. **`createBackgroundWindow()` → `WEB_CORE_ADDRESS` → `app/background.html` → `app/index.js`** — this is the *core background renderer*, not a test fixture. Always created at startup. Runs `app/index.js` (session manager, pubsub hub). Migrate to a v2 resident renderer with a `createTrustedBuiltinGrant('core')` token (same shape as cmd/hud/page/test). 101 101 2. **Webview preload injection in `entry.ts:179`** — every `peek://` webview (widget panes, HUD children, page canvas children) gets the v1 `preload.js` injected via `will-attach-webview`. Switch to `tile-preload.cjs` (or remove if widgets don't need the API). 102 - 3. **`createExtensionWindow()`** — used for external builtins (e.g. `example`) and chrome extensions. Migrate to the v2 tile launcher path or document why it stays. 102 + 3. **`createExtensionWindow()`** — Phase 2.5 #3 audit found 8 callers: 4 dead (deleted in `25c154ea`, -110 LOC); 0 v2-migratable builtins (`example` is already on `loadV2Tile`); 0 chrome extensions (those use `session.loadExtension()`, separate path). 2 live callers remain: `reloadExtension()` (features-manager UI reload button) and `loadDevExtension()` (`--load-extension` CLI flag). They need a `relaunchTile(tileId)` helper in `tile-launcher.ts` (re-read manifest, revoke old token via `revokeTokensForTile`, close old window, call `launchTile`). Once that helper exists, both callers migrate and `createExtensionWindow` can be deleted entirely. Phase 2.5 #3b. 103 103 4. **Dead-code cleanup that's safe today:** `CONSOLIDATED_EXTENSION_IDS` list (always empty after v2 migration), the `if (consolidatedIds.length > 0)` block in `loadExtensions()`, the `loadExtInHost` helper. Safe to delete now since no v2 feature uses them — preserved only because their removal interacts with smoke tests asserting on `peek://app/extension-host.html` existence. 104 104 5. ~~Tauri mobile uses `preload.js` via `include_str!`~~ **Out of scope.** No Tauri/mobile work in this v1-removal pass. If deleting `preload.js` from Electron's path would break Tauri's `include_str!`, copy the file into a Tauri-local path first (e.g. `backend/tauri/src-tauri/src/preload.js`) and update the include — Tauri keeps its v1 surface untouched. The Electron-side cleanup proceeds regardless. 105 105