Bluesky app fork with some witchin' additions 💫
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Boolean filter improvement alternative: TS upgrade (#4840)

* upgrade typescript and use new feature

* fix: typing error

authored by

Dmitrii Kartashev and committed by
GitHub
4437b9a5 50769b0b

+12 -10
+1 -1
package.json
··· 270 270 "react-scripts": "^5.0.1", 271 271 "react-test-renderer": "18.2.0", 272 272 "ts-node": "^10.9.1", 273 - "typescript": "^5.3.3", 273 + "typescript": "^5.5.4", 274 274 "url-loader": "^4.1.1", 275 275 "webpack": "^5.75.0", 276 276 "webpack-bundle-analyzer": "^4.10.1",
+3 -1
src/components/dialogs/ThreadgateEditor.tsx
··· 74 74 75 75 const onPressAudience = (setting: ThreadgateSetting) => { 76 76 // remove nobody 77 - let newSelected = draft.filter(v => v.type !== 'nobody') 77 + let newSelected: ThreadgateSetting[] = draft.filter( 78 + v => v.type !== 'nobody', 79 + ) 78 80 // toggle 79 81 const i = newSelected.findIndex(v => isEqual(v, setting)) 80 82 if (i === -1) {
+2 -2
src/state/queries/post-feed.ts
··· 375 375 } 376 376 return undefined 377 377 }) 378 - .filter(<T>(n?: T): n is T => Boolean(n)), 378 + .filter(n => !!n), 379 379 } 380 380 return feedPostSlice 381 381 }) 382 - .filter(<T>(n?: T): n is T => Boolean(n)), 382 + .filter(n => !!n), 383 383 })), 384 384 ], 385 385 }
+1 -1
src/state/queries/threadgate.ts
··· 33 33 } 34 34 return setting 35 35 }) 36 - .filter(<T>(n?: T): n is T => Boolean(n)) 36 + .filter(n => !!n) 37 37 return settings 38 38 }
+1 -1
src/view/screens/Search/Explore.tsx
··· 119 119 } 120 120 return loadMoreItem 121 121 }) 122 - .filter(<T,>(n?: T): n is T => Boolean(n)) 122 + .filter(n => !!n) 123 123 }, [item.items, moderationOpts]) 124 124 125 125 if (items.length === 0) return null
+4 -4
yarn.lock
··· 21378 21378 dependencies: 21379 21379 is-typedarray "^1.0.0" 21380 21380 21381 - typescript@^5.3.3: 21382 - version "5.3.3" 21383 - resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.3.3.tgz#b3ce6ba258e72e6305ba66f5c9b452aaee3ffe37" 21384 - integrity sha512-pXWcraxM0uxAS+tN0AG/BF2TyqmHO014Z070UsJ+pFvYuRSq8KH8DmWpnbXe0pEPDHXZV3FcAbJkijJ5oNEnWw== 21381 + typescript@^5.5.4: 21382 + version "5.5.4" 21383 + resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.5.4.tgz#d9852d6c82bad2d2eda4fd74a5762a8f5909e9ba" 21384 + integrity sha512-Mtq29sKDAEYP7aljRgtPOpTvOfbwRWlS6dPRzwjdE+C0R4brX/GUyhHSecbHMFLNBLcJIPt9nl9yG5TZ1weH+Q== 21385 21385 21386 21386 ua-parser-js@^0.7.33: 21387 21387 version "0.7.35"