bwc9876.dev / witchsky.app
forked from jollywhoppers.com/witchsky.app
Bluesky app fork with some witchin' additions 💫
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Adjustments to ALF prompt buttons (Dialogs Pt. 2) (#3144)

* Improve a11y on ios

* Format

* Remove android

* Fix android

* small adjustment to buttons in prompt

* full width below gtmobile

* Revert some changes

* use sharedvalue for `importantForAccessibility`

* add back `isOpen`

* fix some more types

* small adjustment to buttons in prompt

* full width below gtmobile

---------

Co-authored-by: Eric Bailey <git@esb.lol>

authored by

Hailey
Eric Bailey and committed by
GitHub 62e57c3b 8ee325e7

+8 -5
+3 -1
src/components/Button.tsx
··· 27 27 | 'gradient_sunset' 28 28 | 'gradient_nordic' 29 29 | 'gradient_bonfire' 30 - export type ButtonSize = 'tiny' | 'small' | 'large' 30 + export type ButtonSize = 'tiny' | 'small' | 'medium' | 'large' 31 31 export type ButtonShape = 'round' | 'square' | 'default' 32 32 export type VariantProps = { 33 33 /** ··· 274 274 if (shape === 'default') { 275 275 if (size === 'large') { 276 276 baseStyles.push({paddingVertical: 15}, a.px_2xl, a.rounded_sm, a.gap_md) 277 + } else if (size === 'medium') { 278 + baseStyles.push({paddingVertical: 12}, a.px_2xl, a.rounded_sm, a.gap_md) 277 279 } else if (size === 'small') { 278 280 baseStyles.push({paddingVertical: 9}, a.px_lg, a.rounded_sm, a.gap_sm) 279 281 } else if (size === 'tiny') {
+5 -4
src/components/Prompt.tsx
··· 78 78 <View 79 79 style={[ 80 80 a.w_full, 81 - a.flex_row, 82 81 a.gap_sm, 83 82 a.justify_end, 84 - gtMobile && [a.pb_4xl], 83 + gtMobile ? [a.flex_row] : [a.flex_col, a.pt_md, a.pb_4xl], 85 84 ]}> 86 85 {children} 87 86 </View> ··· 92 91 children, 93 92 }: React.PropsWithChildren<{onPress?: PressableProps['onPress']}>) { 94 93 const {_} = useLingui() 94 + const {gtMobile} = useBreakpoints() 95 95 const {close} = Dialog.useDialogContext() 96 96 return ( 97 97 <Button 98 98 variant="solid" 99 99 color="secondary" 100 - size="small" 100 + size={gtMobile ? 'small' : 'medium'} 101 101 label={_(msg`Cancel`)} 102 102 onPress={() => close()}> 103 103 {children} ··· 110 110 onPress, 111 111 }: React.PropsWithChildren<{onPress?: () => void}>) { 112 112 const {_} = useLingui() 113 + const {gtMobile} = useBreakpoints() 113 114 const {close} = Dialog.useDialogContext() 114 115 const handleOnPress = React.useCallback(() => { 115 116 close() ··· 119 120 <Button 120 121 variant="solid" 121 122 color="primary" 122 - size="small" 123 + size={gtMobile ? 'small' : 'medium'} 123 124 label={_(msg`Confirm`)} 124 125 onPress={handleOnPress}> 125 126 {children}