Bluesky app fork with some witchin' additions 💫
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Remove dead code for pager (#2651)

authored by

dan and committed by
GitHub
b7056365 f0e046a4

+13 -35
+4 -12
src/view/com/pager/Pager.tsx
··· 22 22 export type RenderTabBarFn = (props: RenderTabBarFnProps) => JSX.Element 23 23 24 24 interface Props { 25 - tabBarPosition?: 'top' | 'bottom' 26 25 initialPage?: number 27 26 renderTabBar: RenderTabBarFn 28 27 onPageSelected?: (index: number) => void ··· 36 35 function PagerImpl( 37 36 { 38 37 children, 39 - tabBarPosition = 'top', 40 38 initialPage = 0, 41 39 renderTabBar, 42 40 onPageScrollStateChanged, ··· 122 120 123 121 return ( 124 122 <View testID={testID} style={s.flex1}> 125 - {tabBarPosition === 'top' && 126 - renderTabBar({ 127 - selectedPage, 128 - onSelect: onTabBarSelect, 129 - })} 123 + {renderTabBar({ 124 + selectedPage, 125 + onSelect: onTabBarSelect, 126 + })} 130 127 <AnimatedPagerView 131 128 ref={pagerView} 132 129 style={s.flex1} ··· 136 133 onPageScroll={onPageScroll}> 137 134 {children} 138 135 </AnimatedPagerView> 139 - {tabBarPosition === 'bottom' && 140 - renderTabBar({ 141 - selectedPage, 142 - onSelect: onTabBarSelect, 143 - })} 144 136 </View> 145 137 ) 146 138 },
+5 -13
src/view/com/pager/Pager.web.tsx
··· 11 11 export type RenderTabBarFn = (props: RenderTabBarFnProps) => JSX.Element 12 12 13 13 interface Props { 14 - tabBarPosition?: 'top' | 'bottom' 15 14 initialPage?: number 16 15 renderTabBar: RenderTabBarFn 17 16 onPageSelected?: (index: number) => void ··· 20 19 export const Pager = React.forwardRef(function PagerImpl( 21 20 { 22 21 children, 23 - tabBarPosition = 'top', 24 22 initialPage = 0, 25 23 renderTabBar, 26 24 onPageSelected, ··· 72 70 73 71 return ( 74 72 <View style={s.hContentRegion}> 75 - {tabBarPosition === 'top' && 76 - renderTabBar({ 77 - selectedPage, 78 - tabBarAnchor: <View ref={anchorRef} />, 79 - onSelect: onTabBarSelect, 80 - })} 73 + {renderTabBar({ 74 + selectedPage, 75 + tabBarAnchor: <View ref={anchorRef} />, 76 + onSelect: onTabBarSelect, 77 + })} 81 78 {React.Children.map(children, (child, i) => ( 82 79 <View style={selectedPage === i ? s.flex1 : s.hidden} key={`page-${i}`}> 83 80 {child} 84 81 </View> 85 82 ))} 86 - {tabBarPosition === 'bottom' && 87 - renderTabBar({ 88 - selectedPage, 89 - onSelect: onTabBarSelect, 90 - })} 91 83 </View> 92 84 ) 93 85 })
+1 -2
src/view/com/pager/PagerWithHeader.tsx
··· 183 183 initialPage={initialPage} 184 184 onPageSelected={onPageSelectedInner} 185 185 onPageSelecting={onPageSelecting} 186 - renderTabBar={renderTabBar} 187 - tabBarPosition="top"> 186 + renderTabBar={renderTabBar}> 188 187 {toArray(children) 189 188 .filter(Boolean) 190 189 .map((child, i) => {
+1 -2
src/view/com/pager/PagerWithHeader.web.tsx
··· 76 76 initialPage={initialPage} 77 77 onPageSelected={onPageSelectedInner} 78 78 onPageSelecting={onPageSelecting} 79 - renderTabBar={renderTabBar} 80 - tabBarPosition="top"> 79 + renderTabBar={renderTabBar}> 81 80 {toArray(children) 82 81 .filter(Boolean) 83 82 .map((child, i) => {
+2 -4
src/view/screens/Home.tsx
··· 184 184 initialPage={clamp(selectedPageIndex, 0, customFeeds.length)} 185 185 onPageSelected={onPageSelected} 186 186 onPageScrollStateChanged={onPageScrollStateChanged} 187 - renderTabBar={renderTabBar} 188 - tabBarPosition="top"> 187 + renderTabBar={renderTabBar}> 189 188 <FeedPage 190 189 key="1" 191 190 testID="followingFeedPage" ··· 212 211 testID="homeScreen" 213 212 onPageSelected={onPageSelected} 214 213 onPageScrollStateChanged={onPageScrollStateChanged} 215 - renderTabBar={renderTabBar} 216 - tabBarPosition="top"> 214 + renderTabBar={renderTabBar}> 217 215 <HomeLoggedOutCTA /> 218 216 </Pager> 219 217 )
-2
src/view/screens/Search/Search.tsx
··· 337 337 if (hasSession) { 338 338 return query ? ( 339 339 <Pager 340 - tabBarPosition="top" 341 340 onPageSelected={onPageSelected} 342 341 renderTabBar={props => ( 343 342 <CenteredView ··· 380 379 381 380 return query ? ( 382 381 <Pager 383 - tabBarPosition="top" 384 382 onPageSelected={onPageSelected} 385 383 renderTabBar={props => ( 386 384 <CenteredView