forked from
npmx.dev/npmx.dev
[READ-ONLY]
a fast, modern browser for the npm registry
test: avoid redundant html validation (#1083)
Co-authored-by: Daniel Roe <daniel@roe.dev>
authored by
Marcus Blättermann
Daniel Roe
and committed by
GitHub
48fa0410
352ec4fb
+10
-6
+4
-2
.github/workflows/ci.yml
+4
-2
.github/workflows/ci.yml
···
150
150
run: pnpm install
151
151
152
152
- name: 🏗️ Build project
153
-
run: pnpm build:playwright
153
+
run: pnpm build:test
154
+
env:
155
+
VALIDATE_HTML: true
154
156
155
157
- name: 🖥️ Test project (browser)
156
158
run: pnpm test:browser:prebuilt
···
178
180
run: pnpm install
179
181
180
182
- name: 🏗️ Build project
181
-
run: NODE_ENV=test pnpm build
183
+
run: pnpm build:test
182
184
183
185
- name: ♿ Accessibility audit (Lighthouse - ${{ matrix.mode }} mode)
184
186
run: ./scripts/lighthouse-a11y.sh
+2
nuxt.config.ts
+2
nuxt.config.ts
···
1
1
import process from 'node:process'
2
2
import { currentLocales } from './config/i18n'
3
+
import { isCI, provider } from 'std-env'
3
4
4
5
export default defineNuxtConfig({
5
6
modules: [
···
195
196
},
196
197
197
198
htmlValidator: {
199
+
enabled: !isCI || (provider !== 'vercel' && !!process.env.VALIDATE_HTML),
198
200
failOnError: true,
199
201
},
200
202
+4
-4
package.json
+4
-4
package.json
···
12
12
"scripts": {
13
13
"build": "nuxt build",
14
14
"build:lunaria": "node ./lunaria/lunaria.ts",
15
-
"build:playwright": "NODE_ENV=test pnpm build",
15
+
"build:test": "NODE_ENV=test pnpm build",
16
16
"dev": "nuxt dev",
17
17
"dev:docs": "pnpm run --filter npmx-docs dev --port=3001",
18
18
"i18n:check": "node scripts/compare-translations.ts",
···
30
30
"generate:fixtures": "node scripts/generate-fixtures.ts",
31
31
"generate:lexicons": "lex build --lexicons lexicons --out shared/types/lexicons --clear",
32
32
"test": "vite test",
33
-
"test:browser": "pnpm build:playwright && pnpm test:browser:prebuilt",
33
+
"test:browser": "pnpm build:test && pnpm test:browser:prebuilt",
34
34
"test:browser:prebuilt": "playwright test",
35
-
"test:browser:ui": "pnpm build:playwright && pnpm test:browser:prebuilt --ui",
36
-
"test:browser:update": "pnpm build:playwright && pnpm test:browser:prebuilt --update-snapshots",
35
+
"test:browser:ui": "pnpm build:test && pnpm test:browser:prebuilt --ui",
36
+
"test:browser:update": "pnpm build:test && pnpm test:browser:prebuilt --update-snapshots",
37
37
"test:nuxt": "vite test --project nuxt",
38
38
"test:types": "pnpm generate:lexicons && nuxt prepare && vue-tsc -b --noEmit && pnpm --filter npmx-connector test:types",
39
39
"test:unit": "vite test --project unit",