edouard.paris / crosspoint-reader
A fork of https://github.com/crosspoint-reader/crosspoint-reader
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Add a bullet to the beginning of any <li> (#368)

Currently there is no visual indication whatsoever if something is in a
list. An `<li>` is essentially just another paragraph.

As a partial remedy for this, add a bullet character to the beginning of
`<li>` text blocks so that the user can see that they're list items.
This is incomplete in that an `<ol>` should also have a counter so that
its list items can get numbers instead of bullets (right now I don't
think we track if we're in a `<ul>` or an `<ol>` at all), but it's
strictly better than the current situation.

Co-authored-by: Maeve Andrews <maeve@git.mail.maeveandrews.com>

authored by

Maeve Andrews
Maeve Andrews and committed by
GitHub e517945a 48922083

+3
+3
lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp
··· 97 97 self->startNewTextBlock(self->currentTextBlock->getStyle()); 98 98 } else { 99 99 self->startNewTextBlock((TextBlock::Style)self->paragraphAlignment); 100 + if (strcmp(name, "li") == 0) { 101 + self->currentTextBlock->addWord("\xe2\x80\xa2", EpdFontFamily::REGULAR); 102 + } 100 103 } 101 104 } else if (matches(name, BOLD_TAGS, NUM_BOLD_TAGS)) { 102 105 self->boldUntilDepth = std::min(self->boldUntilDepth, self->depth);