A Kubernetes operator that bridges Hardware Security Module (HSM) data storage with Kubernetes Secrets, providing true secret portability th
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

fix linter

+5 -6
+5 -6
internal/controller/hsmsecret_controller.go
··· 148 148 149 149 // Handle deletion 150 150 if hsmSecret.DeletionTimestamp != nil { 151 - return r.reconcileDelete(ctx, &hsmSecret) 151 + return ctrl.Result{}, r.reconcileDelete(ctx, &hsmSecret) 152 152 } 153 153 154 154 // Add finalizer if not present ··· 281 281 282 282 return r.updateKubernetesSecret(ctx, hsmSecret, secretName, hsmData, hsmMetadata, syncInterval) 283 283 } 284 - 285 284 286 285 // readFromAllDevices reads the secret from all devices with version information 287 286 func (r *HSMSecretReconciler) readFromAllDevices(ctx context.Context, hsmSecret *hsmv1alpha1.HSMSecret, deviceClients *HSMDeviceClients) (map[string]*DeviceInfo, string, error) { ··· 519 518 } 520 519 521 520 // reconcileDelete handles HSMSecret deletion 522 - func (r *HSMSecretReconciler) reconcileDelete(ctx context.Context, hsmSecret *hsmv1alpha1.HSMSecret) (ctrl.Result, error) { 521 + func (r *HSMSecretReconciler) reconcileDelete(ctx context.Context, hsmSecret *hsmv1alpha1.HSMSecret) error { 523 522 logger := log.FromContext(ctx) 524 523 525 524 if controllerutil.ContainsFinalizer(hsmSecret, HSMSecretFinalizer) { ··· 540 539 if err := r.Get(ctx, secretKey, &k8sSecret); err == nil { 541 540 if err := r.Delete(ctx, &k8sSecret); err != nil { 542 541 logger.Error(err, "Failed to delete associated Secret") 543 - return ctrl.Result{}, err 542 + return err 544 543 } 545 544 logger.Info("Deleted associated Secret", "secret", secretKey) 546 545 } ··· 549 548 controllerutil.RemoveFinalizer(hsmSecret, HSMSecretFinalizer) 550 549 if err := r.Update(ctx, hsmSecret); err != nil { 551 550 logger.Error(err, "Failed to remove finalizer") 552 - return ctrl.Result{}, err 551 + return err 553 552 } 554 553 } 555 554 556 - return ctrl.Result{}, nil 555 + return nil 557 556 } 558 557 559 558 // buildSecret creates a new Kubernetes Secret from HSM data and metadata