Opinionated OCaml linter with Merlin integration for code quality, naming conventions, and style checks
fix(lint): resolve E320, E331, E410, E415, E505, E510 across multiple packages
E505: add missing .mli files for merlint/lib/sexp, monopam-info, and
monopam/lib/{add,clean,ctx,diff,init,pull,push,remove}.
E510: add log source to ca-certs/test/tests.ml.
E410: fix doc ending period in kdf/scrypt.
E415: add pp to ocaml-agent config and runtime_config.
E331: remove redundant get_/make_/find_/create_ prefixes.
E320: remove redundant module prefixes (Diff.diff→compute,
Pull.pull→run, Push.push→run, Remove.remove→run, etc).
+13
-15
+13
-15
test/test_outline.ml
+13
-15
test/test_outline.ml
···
3
3
open Merlint.Outline
4
4
5
5
(* Helper to create test items *)
6
-
let make_item ?(type_sig = None) ?(deprecated = false) ?(children = []) ~name
7
-
~kind () =
6
+
let item ?(type_sig = None) ?(deprecated = false) ?(children = []) ~name ~kind
7
+
() =
8
8
{
9
9
Merlin.name;
10
10
kind;
···
25
25
26
26
let test_flatten_simple () =
27
27
let items =
28
-
[
29
-
make_item ~name:"foo" ~kind:Value (); make_item ~name:"bar" ~kind:Type ();
30
-
]
28
+
[ item ~name:"foo" ~kind:Value (); item ~name:"bar" ~kind:Type () ]
31
29
in
32
30
let result = flatten items in
33
31
Alcotest.(check int) "two items" 2 (List.length result)
34
32
35
33
let test_flatten_with_children () =
36
-
let child = make_item ~name:"inner" ~kind:Value () in
37
-
let parent = make_item ~name:"Outer" ~kind:Module ~children:[ child ] () in
34
+
let child = item ~name:"inner" ~kind:Value () in
35
+
let parent = item ~name:"Outer" ~kind:Module ~children:[ child ] () in
38
36
let result = flatten [ parent ] in
39
37
Alcotest.(check int) "parent and child" 2 (List.length result)
40
38
41
39
let test_get_values () =
42
40
let items =
43
41
[
44
-
make_item ~name:"foo" ~kind:Value ~type_sig:(Some "int") ();
45
-
make_item ~name:"Bar" ~kind:Type ();
46
-
make_item ~name:"baz" ~kind:Value ~type_sig:(Some "string") ();
42
+
item ~name:"foo" ~kind:Value ~type_sig:(Some "int") ();
43
+
item ~name:"Bar" ~kind:Type ();
44
+
item ~name:"baz" ~kind:Value ~type_sig:(Some "string") ();
47
45
]
48
46
in
49
47
···
55
53
let test_find_by_name () =
56
54
let items =
57
55
[
58
-
make_item ~name:"foo" ~kind:Value ~type_sig:(Some "int") ();
59
-
make_item ~name:"Bar" ~kind:Type ();
56
+
item ~name:"foo" ~kind:Value ~type_sig:(Some "int") ();
57
+
item ~name:"Bar" ~kind:Type ();
60
58
]
61
59
in
62
60
···
68
66
Alcotest.(check bool) "not found baz" true (not_found = None)
69
67
70
68
let test_find_nested () =
71
-
let child = make_item ~name:"nested" ~kind:Value () in
72
-
let parent = make_item ~name:"M" ~kind:Module ~children:[ child ] () in
69
+
let child = item ~name:"nested" ~kind:Value () in
70
+
let parent = item ~name:"M" ~kind:Module ~children:[ child ] () in
73
71
let found = by_name "nested" [ parent ] in
74
72
Alcotest.(check bool) "found nested" true (found <> None);
75
73
Alcotest.(check string) "correct name" "nested" (Option.get found).name
···
92
90
in
93
91
List.iter
94
92
(fun (kind, name) ->
95
-
let item = make_item ~name ~kind () in
93
+
let item = item ~name ~kind () in
96
94
Alcotest.(check string) (Fmt.str "%s kind" name) name item.name)
97
95
kinds
98
96