Opinionated OCaml linter with Merlin integration for code quality, naming conventions, and style checks
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

csv: rename from csvt

Drops the redundant "t" suffix. Library name, opam package, module
(Csvt -> Csv), and directory all rename in lockstep. Every downstream
reference in interop tests, libraries, and docs updated.

+10 -12
+3 -5
lib/rules/e820.ml
··· 25 25 dirs 26 26 27 27 let pp ppf { dir } = 28 - Fmt.pf ppf "Interop test %s/test.ml hand-rolls CSV parsing instead of csvt" 29 - dir 28 + Fmt.pf ppf "Interop test %s/test.ml hand-rolls CSV parsing instead of csv" dir 30 29 31 30 let rule = 32 31 Rule.v ~code:"E820" ~title:"Hand-rolled CSV parsing" ~category:Interop_testing 33 32 ~hint: 34 - "Use csvt (Csvt.decode_file with a Csvt.Row codec) for CSV trace \ 35 - parsing. Never hand-roll CSV readers with \ 36 - open_in/input_line/split_on_char." 33 + "Use csv (Csv.decode_file with a Csv.Row codec) for CSV trace parsing. \ 34 + Never hand-roll CSV readers with open_in/input_line/split_on_char." 37 35 ~examples:[] ~pp (Project check)
+7 -7
lib/rules/e825.ml
··· 1 - (** E825: Interop test uses CSV traces but dune lacks csvt dependency *) 1 + (** E825: Interop test uses CSV traces but dune lacks csv dependency *) 2 2 3 3 type payload = { dir : string } 4 4 ··· 16 16 in 17 17 if has_csv then 18 18 let dune = Interop.dune_content d.path in 19 - if not (Astring.String.is_infix ~affix:"csvt" dune) then 19 + if not (Astring.String.is_infix ~affix:"csv" dune) then 20 20 Some (Issue.v { dir = d.path }) 21 21 else None 22 22 else None ··· 24 24 dirs 25 25 26 26 let pp ppf { dir } = 27 - Fmt.pf ppf "Interop test %s has CSV traces but dune lacks csvt dependency" dir 27 + Fmt.pf ppf "Interop test %s has CSV traces but dune lacks csv dependency" dir 28 28 29 29 let rule = 30 - Rule.v ~code:"E825" ~title:"Missing csvt dependency" ~category:Interop_testing 30 + Rule.v ~code:"E825" ~title:"Missing csv dependency" ~category:Interop_testing 31 31 ~hint: 32 - "Interop tests with CSV traces should use csvt for parsing. Add csvt to \ 33 - the (libraries ...) in the dune file and use Csvt.decode_file with a \ 34 - Row codec." 32 + "Interop tests with CSV traces should use csv for parsing. Add csv to \ 33 + the (libraries ...) in the dune file and use Csv.decode_file with a Row \ 34 + codec." 35 35 ~examples:[] ~pp (Project check)