User authentication and session management for web applications
auth: fix catch-all handler, rename find_or_create_user (merlint E100/E325)
+3
-3
+2
-2
lib/auth.ml
+2
-2
lib/auth.ml
···
354
354
(* Find or create a user from OAuth userinfo, handling concurrent races.
355
355
Requires a verified email — returns Error if the provider did not supply
356
356
one or if email_verified is false. *)
357
-
let find_or_create_user store ~provider ~ui =
357
+
let get_or_create_user store ~provider ~ui =
358
358
let provider_uid = ui.Oauth.uid in
359
359
match (ui.Oauth.email, ui.email_verified) with
360
360
| None, _ | _, false ->
···
404
404
let provider =
405
405
Oauth.provider_name cfg.session.oauth_provider
406
406
in
407
-
match find_or_create_user store ~provider ~ui with
407
+
match get_or_create_user store ~provider ~ui with
408
408
| Error e ->
409
409
Log.warn (fun m -> m "callback: %s" e);
410
410
Respond.Response.bad_request e
+1
-1
test/test_auth.ml
+1
-1
test/test_auth.ml
···
26
26
Eio.Path.save ~create:(`Or_truncate 0o644) path garbage;
27
27
let raised = ref false in
28
28
(try Eio.Switch.run @@ fun sw -> ignore (Auth.Store.v ~sw path)
29
-
with _ -> raised := true);
29
+
with Eio.Io _ | Failure _ -> raised := true);
30
30
Alcotest.(check bool) "invalid db raises" true !raised;
31
31
Alcotest.(check string) "file preserved" garbage (Eio.Path.load path)
32
32