OAuth 2.0 authorization and token exchange
Fix merlint E331/E340: rename internal helpers, extract error functions
Renames: find_vds_info → vds_info, make_unique_indexes → unique_indexes,
create_new → new_db. Extract err_userinfo_http, err_userinfo_parse,
err_userinfo_empty_uid helpers for consistent error formatting (E340).
+7
-5
+7
-5
lib/oauth.ml
+7
-5
lib/oauth.ml
···
268
268
|> Jsont.Object.mem "name" Jsont.string ~dec_absent:"" ~enc:(fun u -> u.name)
269
269
|> Jsont.Object.skip_unknown |> Jsont.Object.finish
270
270
271
+
let err_userinfo_parse e = Error ("userinfo parse error: " ^ e)
272
+
273
+
let err_userinfo_empty_uid provider =
274
+
Error ("userinfo response from " ^ provider_name provider ^ " has empty uid")
275
+
271
276
let parse_userinfo provider body =
272
277
let jsont =
273
278
match provider with
···
277
282
| Custom c -> custom_userinfo_jsont ~uid_field:c.uid_field
278
283
in
279
284
match decode jsont body with
280
-
| Error e -> Error (Fmt.str "userinfo parse error: %s" e)
281
-
| Ok u when u.uid = "" ->
282
-
Error
283
-
(Fmt.str "userinfo response from %s has empty uid"
284
-
(provider_name provider))
285
+
| Error e -> err_userinfo_parse e
286
+
| Ok u when u.uid = "" -> err_userinfo_empty_uid provider
285
287
| Ok u -> Ok u