RPMsg inter-partition messaging
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

fix(lint): remove redundant function prefixes (E331)

Strip get_/make_/find_/create_ from 138 function definitions and all
call sites across ocaml-pds, ocaml-pid1, ocaml-precommit,
ocaml-publicsuffix, ocaml-qemu, ocaml-requests, ocaml-retry, and
ocaml-rpmsg. Use Module.v for constructors per the E331 convention.

+5 -7
+5 -7
test/test_wire.ml
··· 73 73 74 74 (** Build a raw 40-byte rpmsg_endpoint_info in kernel layout: name[32] 75 75 (null-padded) || src:u32le || dst:u32le *) 76 - let make_raw_info name src dst = 76 + let raw_info name src dst = 77 77 let buf = Bytes.make 40 '\x00' in 78 78 let len = min (String.length name) 31 in 79 79 Bytes.blit_string name 0 buf 0 len; ··· 91 91 92 92 let test_decode_known_vector () = 93 93 (* Kernel self-test default: rpmsg-client-sample with RPMSG_ADDR_ANY *) 94 - let raw = make_raw_info "rpmsg-client-sample" rpmsg_addr_any rpmsg_addr_any in 94 + let raw = raw_info "rpmsg-client-sample" rpmsg_addr_any rpmsg_addr_any in 95 95 let decoded = Wire.Codec.decode Rpmsg.endpoint_info_codec raw 0 in 96 96 Alcotest.(check bool) 97 97 "name" true ··· 111 111 in 112 112 let buf = Bytes.create 40 in 113 113 Wire.Codec.encode Rpmsg.endpoint_info_codec info buf 0; 114 - let expected = 115 - make_raw_info "rpmsg-client-sample" rpmsg_addr_any rpmsg_addr_any 116 - in 114 + let expected = raw_info "rpmsg-client-sample" rpmsg_addr_any rpmsg_addr_any in 117 115 Alcotest.(check string) 118 116 "wire bytes" (Bytes.to_string expected) (Bytes.to_string buf) 119 117 120 118 let test_decode_openamp_vector () = 121 119 (* OpenAMP demo channel: name="rpmsg-openamp-demo-channel", src=1024, dst=1025 122 120 Common on Zynq UltraScale+ and STM32MP1 targets. *) 123 - let raw = make_raw_info "rpmsg-openamp-demo-channel" 1024 1025 in 121 + let raw = raw_info "rpmsg-openamp-demo-channel" 1024 1025 in 124 122 let decoded = Wire.Codec.decode Rpmsg.endpoint_info_codec raw 0 in 125 123 Alcotest.(check bool) 126 124 "name" true ··· 134 132 in 135 133 let buf = Bytes.create 40 in 136 134 Wire.Codec.encode Rpmsg.endpoint_info_codec info buf 0; 137 - let expected = make_raw_info "rpmsg-openamp-demo-channel" 1024 1025 in 135 + let expected = raw_info "rpmsg-openamp-demo-channel" 1024 1025 in 138 136 Alcotest.(check string) 139 137 "wire bytes" (Bytes.to_string expected) (Bytes.to_string buf) 140 138