"Das U-Boot" Source Tree
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

cmd: sound: fix help text

There's never been a -q or -s argument handled in the command, so let's
remove it. This was highlighted during review[1] but somehow still got
through.

While at it, slightly "reword" in the help text how the len + freq
arguments are defined. Indeed, len and freq work in pair, it is possible
to define none of either, n of both, or n - 1 of freq if there are n
len, in which case the freq that goes with the last len would be the n -
1 (and not the default of 400Hz if neither len nor freq is passed). I
assume this isn't what's expected but leaving it for another patch if
need be to fix what happens in that very odd scenario.

[1] https://lore.kernel.org/u-boot/CAPnjgZ0QWNqVFZfEWHxRcFOA3E3gRAZCYs77nGUXKL0pLp+JLQ@mail.gmail.com/

Fixes: ea58b9a404d4 ("cmd: allow sound command to play multiple sounds")
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Simon Glass <sjg@chromium.org>

authored by

Quentin Schulz and committed by
Tom Rini
ca6a992e 53de4841

+1 -1
+1 -1
cmd/sound.c
··· 99 99 sound, INT_MAX, 1, do_sound, 100 100 "sound sub-system", 101 101 "init - initialise the sound driver\n" 102 - "sound play [[[-q|-s] len [freq]] ...] - play sounds\n" 102 + "sound play [len [freq [len [freq ...]]]] - play sounds\n" 103 103 " len - duration in ms\n" 104 104 " freq - frequency in Hz\n" 105 105 );