Bluesky app fork with some witchin' additions 💫
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Merge pull request #692 from bluesky-social/ollie/unread-notifications

Update hint for notifications

authored by

Ollie H and committed by
GitHub
0ca09613 562faa76

+12 -3
+5 -1
src/view/shell/Drawer.tsx
··· 222 222 } 223 223 label="Notifications" 224 224 accessibilityLabel="Notifications" 225 - accessibilityHint={`${store.me.notifications.unreadCountLabel} unread`} 225 + accessibilityHint={ 226 + notifications.unreadCountLabel === '' 227 + ? '' 228 + : `${notifications.unreadCountLabel} unread` 229 + } 226 230 count={notifications.unreadCountLabel} 227 231 bold={isAtNotifications} 228 232 onPress={onPressNotifications}
+7 -2
src/view/shell/bottom-bar/BottomBar.tsx
··· 38 38 useNavigationTabState() 39 39 40 40 const {footerMinimalShellTransform} = useMinimalShellMode() 41 + const {notifications} = store.me 41 42 42 43 const onPressTab = React.useCallback( 43 44 (tab: string) => { ··· 138 139 ) 139 140 } 140 141 onPress={onPressNotifications} 141 - notificationCount={store.me.notifications.unreadCountLabel} 142 + notificationCount={notifications.unreadCountLabel} 142 143 accessible={true} 143 144 accessibilityRole="tab" 144 145 accessibilityLabel="Notifications" 145 - accessibilityHint={`${store.me.notifications.unreadCountLabel} unread`} 146 + accessibilityHint={ 147 + notifications.unreadCountLabel === '' 148 + ? '' 149 + : `${notifications.unreadCountLabel} unread` 150 + } 146 151 /> 147 152 <Btn 148 153 testID="bottomBarProfileBtn"