jon.recoil.org / js_top_worker
this repo has no description
0
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix cram test: add unix library and update for OCaml 5.4.0

The unix_worker was crashing at startup with:
Fatal error: cannot load shared library dllos_ipc_stubs
Reason: undefined symbol: caml_uerror

This happened because merlin-lib's os_ipc C stubs depend on caml_uerror
from the Unix library, but in bytecode mode the stubs are loaded
dynamically and the Unix runtime wasn't available yet.

Fix by adding `unix` library explicitly to unix_worker dependencies,
ensuring the Unix C stubs are loaded before os_ipc_stubs.

Also update expected output for OCaml 5.4.0:
- Version string: 5.2.0 -> 5.4.0
- Compiler flag: transparent_modules -> no_alias_deps

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Jon Ludlam 3908ea59 104a91c1

+3 -2
+1
example/dune
··· 45 45 (modules unix_worker) 46 46 (link_flags (-linkall)) 47 47 (libraries 48 + unix 48 49 js_top_worker 49 50 logs 50 51 logs.fmt
+1 -1
idl/toplevel_api_gen.ml
··· 11 11 use_vmthreads = false; 12 12 recursive_types = false; 13 13 principal = false; 14 - transparent_modules = false; 14 + no_alias_deps = false; 15 15 unboxed_types = false; 16 16 unsafe_string = false; 17 17 cookies = [("library-name", "js_top_worker_rpc_def")]
+1 -1
test/cram/simple.t/run.t
··· 6 6 unix_worker: [INFO] Setup complete 7 7 unix_worker: [INFO] setup() finished 8 8 {mime_vals:[];stderr:S(error while evaluating #enable "pretty";; 9 - error while evaluating #disable "shortvar";;);stdout:S(OCaml version 5.2.0 9 + error while evaluating #disable "shortvar";;);stdout:S(OCaml version 5.4.0 10 10 Unknown directive enable. 11 11 Unknown directive disable.)} 12 12 {mime_vals:[];parts:[];script:S(# Printf.printf "Hello, world\n";;