+5

.changeset/lovely-monkeys-wink.md

reviewed

··· 1 1 + --- 2 2 + '@urql/exchange-graphcache': patch 3 3 + --- 4 4 + 5 5 + Fix optimistic mutations containing partial results (`undefined` fields), which previously actually caused a hidden cache miss, which may then affect a subsequent non-optimistic mutation result.

+3 -1

exchanges/graphcache/src/operations/write.ts

reviewed

··· 259 259 // Skip typename fields and assume they've already been written above 260 260 fieldName === '__typename' || 261 261 // Fields marked as deferred that aren't defined must be skipped 262 262 - (fieldValue === undefined && deferRef.current) 262 262 + // Otherwise, we also ignore undefined values in optimistic updaters 263 263 + (fieldValue === undefined && 264 264 + (deferRef.current || (ctx.optimistic && !isRoot))) 263 265 ) { 264 266 continue; 265 267 }

+40

exchanges/graphcache/src/store/store.test.ts

reviewed

··· 784 784 }); 785 785 }); 786 786 787 787 + it('should be able to optimistically mutate with partial data', () => { 788 788 + const { dependencies } = writeOptimistic( 789 789 + store, 790 790 + { 791 791 + query: gql` 792 792 + mutation { 793 793 + addTodo(id: "0", complete: true, __typename: "Todo") { 794 794 + id 795 795 + text 796 796 + complete 797 797 + __typename 798 798 + } 799 799 + } 800 800 + `, 801 801 + }, 802 802 + 1 803 803 + ); 804 804 + expect(dependencies).toEqual(new Set(['Todo:0'])); 805 805 + let { data } = query(store, { query: Todos }); 806 806 + expect(data).toEqual({ 807 807 + __typename: 'Query', 808 808 + todos: [ 809 809 + { 810 810 + ...todosData.todos[0], 811 811 + complete: true, 812 812 + }, 813 813 + todosData.todos[1], 814 814 + todosData.todos[2], 815 815 + ], 816 816 + }); 817 817 + 818 818 + InMemoryData.noopDataState(store.data, 1); 819 819 + 820 820 + ({ data } = query(store, { query: Todos })); 821 821 + expect(data).toEqual({ 822 822 + __typename: 'Query', 823 823 + todos: todosData.todos, 824 824 + }); 825 825 + }); 826 826 + 787 827 describe('Invalidating an entity', () => { 788 828 it('removes an entity from a list.', () => { 789 829 store.invalidate(todosData.todos[1]);