+5

.changeset/bright-jobs-shout.md

reviewed

··· 1 1 + --- 2 2 + 'urql': patch 3 3 + --- 4 4 + 5 5 + don't persist error state of old gql responses after refetch in react state

+42

packages/react-urql/src/hooks/state.test.ts

reviewed

··· 1 1 + import { it, expect, describe } from 'vitest'; 2 2 + import { computeNextState, initialState } from './state'; 3 3 + 4 4 + describe('computeNextState', () => { 5 5 + it('clears error when new result does not include an error key', () => { 6 6 + const prevState = { ...initialState, error: new Error('old error') }; 7 7 + const result = { fetching: false }; 8 8 + const newState = computeNextState(prevState, result); 9 9 + expect(newState.data).toBeUndefined(); 10 10 + expect(newState.error).toBeUndefined(); 11 11 + expect(newState.fetching).toBe(false); 12 12 + }); 13 13 + 14 14 + it('preserves error when new result is still fetching', () => { 15 15 + const error = new Error('old error'); 16 16 + const prevState = { ...initialState, error }; 17 17 + const result = { fetching: true }; 18 18 + const newState = computeNextState(prevState, result); 19 19 + expect(newState.data).toBeUndefined(); 20 20 + expect(newState.error).toBe(error); 21 21 + expect(newState.fetching).toBe(true); 22 22 + }); 23 23 + 24 24 + it('sets error when new result has an error', () => { 25 25 + const error = new Error('something went wrong'); 26 26 + const result = { fetching: false, error }; 27 27 + const newState = computeNextState(initialState, result as any); 28 28 + expect(newState.data).toBeUndefined(); 29 29 + expect(newState.error).toBe(error); 30 30 + expect(newState.fetching).toBe(false); 31 31 + }); 32 32 + 33 33 + it('preserves data when result has no data and no error', () => { 34 34 + const data = { foo: 1 }; 35 35 + const prevState = { ...initialState, data }; 36 36 + const result = { fetching: false }; 37 37 + const newState = computeNextState(prevState, result); 38 38 + expect(newState.data).toBe(data); 39 39 + expect(newState.error).toBeUndefined(); 40 40 + expect(newState.fetching).toBe(false); 41 41 + }); 42 42 + });

+1

packages/react-urql/src/hooks/state.ts

reviewed

··· 55 55 result.data !== undefined || result.error ? result.data : prevState.data, 56 56 fetching: !!result.fetching, 57 57 stale: !!result.stale, 58 58 + error: result.fetching ? prevState.error : result.error, 58 59 }; 59 60 60 61 return isShallowDifferent(prevState, newState) ? newState : prevState;