+5

.changeset/fresh-moose-exist.md

reviewed

··· 1 1 + --- 2 2 + '@urql/core': patch 3 3 + --- 4 4 + 5 5 + Fix accidental change in passive `stale: true`, where a `cache-first` operation issued by Graphcache wouldn't yield an affected query and update its result to reflect the loading state with `stale: true`. This is a regression from `v2.1.0` and mostly becomes unexpected when `cache.invalidate(...)` is used.

+10 -5

packages/core/src/client.test.ts

reviewed

··· 6 6 Source, 7 7 delay, 8 8 map, 9 9 + never, 9 10 pipe, 11 11 + merge, 10 12 subscribe, 11 13 publish, 12 14 filter, ··· 869 871 870 872 it('does nothing when operation is a subscription has been emitted yet', () => { 871 873 const exchange: Exchange = () => ops$ => { 872 872 - return pipe( 873 873 - ops$, 874 874 - map(op => ({ data: 1, operation: op })), 875 875 - take(1) 876 876 - ); 874 874 + return merge([ 875 875 + pipe( 876 876 + ops$, 877 877 + map(op => ({ data: 1, operation: op })), 878 878 + take(1) 879 879 + ), 880 880 + never, 881 881 + ]); 877 882 }; 878 883 879 884 const client = createClient({

+6 -8

packages/core/src/client.ts

reviewed

··· 206 206 ) 207 207 ), 208 208 switchMap(result => { 209 209 - if (result.stale) { 209 209 + if (operation.kind !== 'query' || result.stale) { 210 210 return fromValue(result); 211 211 } 212 212 ··· 215 215 // Mark a result as stale when a new operation is sent for it 216 216 pipe( 217 217 operations$, 218 218 - filter(op => { 219 219 - return ( 220 220 - op.kind === operation.kind && 218 218 + filter( 219 219 + op => 220 220 + op.kind === 'query' && 221 221 op.key === operation.key && 222 222 - (op.context.requestPolicy === 'network-only' || 223 223 - op.context.requestPolicy === 'cache-and-network') 224 224 - ); 225 225 - }), 222 222 + op.context.requestPolicy !== 'cache-only' 223 223 + ), 226 224 take(1), 227 225 map(() => ({ ...result, stale: true })) 228 226 ),